1435880 - Handle moving/detaching tabs between windows when a Payment Request is showing

Status: VERIFIED FIXED

(Firefox :: WebPayments UI, defect, P1)

Description

[Matthew N. [:MattN]]

If a Payment Request tab-modal dialog is showing and the tab is dragged to an existing window or detached to a new window, the Payment Request dialog should continue to be shown in that new window.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1435880 - Put the payment dialog <browser> directly in the ChromeWindow. r=jaws

Remove the intermediate <html:iframe> as it makes support of detaching impossible since we would need
to swap both the <browser> and <html:iframe> contents during a tab detach.
Since a docshell swap requires both docshells to have a frame and document loaded and the move of the
tab won't wait on payments code to do async work to get frames and documents ready for swapping, I
couldn't see a way to get detaching to work with the nested frames.

* Swapping the docshell of only the outer <html:iframe> still caused a reload of the inner <browser>.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1435880 - Handle moving/detaching tabs between windows when a Payment Request is showing. r=jaws,mconley

Depends on D10180

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1435880 - Document how to fix Payment Request autofill strings during dev. r?jaws

Properly populate addressLevel3Label in unprivileged-fallbacks.js to not cause l10n.js errors.

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1435880 - Send temporary records in paymentDialogWrapper.initializeFrame. r=sfoster

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1435880 - Document how to fix Payment Request autofill strings during dev. r?jaws

Properly populate addressLevel3Label in unprivileged-fallbacks.js to not cause l10n.js errors.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3cd9152a9a7
Document how to fix Payment Request autofill strings during dev. r=jaws

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a3cd9152a9a7

Comment 8

[Matthew N. [:MattN]]

Attachment: Bug 1435880 - Temporarily disable test_abortPayment and test_canMakePayment due a new leak exposed. r=edenchuang

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ae95326b134
Send temporary records in paymentDialogWrapper.initializeFrame. r=sfoster
https://hg.mozilla.org/integration/autoland/rev/802dfe1bb501
Put the payment dialog <browser> directly in the ChromeWindow. r=jaws
https://hg.mozilla.org/integration/autoland/rev/8867eaddfa83
Handle moving/detaching tabs between windows when a Payment Request is showing. r=jaws
https://hg.mozilla.org/integration/autoland/rev/dced0862f4bc
Temporarily disable test_abortPayment and test_canMakePayment due a new leak exposed. r=edenchuang

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8ae95326b134
https://hg.mozilla.org/mozilla-central/rev/802dfe1bb501
https://hg.mozilla.org/mozilla-central/rev/8867eaddfa83
https://hg.mozilla.org/mozilla-central/rev/dced0862f4bc

Comment 11

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on the latest Nightly 65.0a1 (2018-11-16) (64-bit) on Windows 7/10 x64, Mac OS 10.13 and Ubuntu 16.04.
The Payment Request dialog is shown after moving the tab to a new window.

I also noticed that since this patch landed I can no longer reproduce https://bugzilla.mozilla.org/show_bug.cgi?id=1501285 since the Payment Widget is instantly displayed as it was before. Is this fix also intended?

Comment 12

[Matthew N. [:MattN]]

Thanks 

(In reply to Timea Babos from comment #11)
> I also noticed that since this patch landed I can no longer reproduce
> https://bugzilla.mozilla.org/show_bug.cgi?id=1501285 since the Payment
> Widget is instantly displayed as it was before. Is this fix also intended?

I assume you're talking about the delay? I wouldn't be surprised if it was slightly faster to display as there is one less intermediate <iframe> to load. That bug is still relevant to https://rsolomakhin.github.io/pr/wait/ where the merchant is slow to provide the complete Payment Request though.

Comment 13

[Timea Cernea [:tbabos][inactive]]

Yes, the delay is what I was thinking about. I was about to ask if I should close that one too, but given your additional info, I understood what is it meant for. 

Thanks Matt

Comment 14

[Matthew N. [:MattN]]

Attachment: Bug 1435880 - Remove stale XUL references from docs along with dead test code.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/606f30cb7499
Remove stale XUL references from docs along with dead test code.

Comment 16

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/606f30cb7499