Open Bug 1507251 Opened 3 years ago Updated 2 years ago

Fix test_abortPayment.html and test_canMakePayment.html to not leak in the tab process

Categories

(Core :: DOM: Web Payments, defect, P2)

defect

Tracking

()

People

(Reporter: MattN, Unassigned)

References

Details

(Whiteboard: [webpayments-reserve])

For bug 1435880 I temporarily disabled the two tests in debug builds as it uncovered a leak in them. Since the leak is in the tab process it didn't seem like the UI changes in bug 1435880 caused the leak. Eden is already investigating it.

> TEST-UNEXPECTED-FAIL | leakcheck | tab process: 5040 bytes leaked (CondVar, Mutex, SchedulerEventTarget, TabGroup, ThrottledEventQueue, ...)[1]

Switching to a testing UI service also hit an assertion at https://searchfox.org/mozilla-central/rev/d850d799a0009f851b5535580e0a8b4bb2c591d7/dom/payments/PaymentRequest.cpp#902 which may be incorrect but I'm not sure.

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=211537419&repo=try&lineNumber=2827
Flags: qe-verify-
Assignee: MattN+bmo → echuang
Priority: P2 → P1

Is this bug still a P1?

Flags: needinfo?(echuang)

I don't think it should be P1. According to my memory, it only leaks when turning Payment UI on. Set P2 or P3 is much more reasonable.

Flags: needinfo?(echuang)
Priority: P1 → P2
Assignee: echuang → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.