Closed Bug 1435896 Opened 6 years ago Closed 6 years ago

WR: Implement Tiled Blob Masks

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox60 --- wontfix
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: Gankra, Assigned: kats)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

gfx/tests/crashtests/1278305.html contains an animation that occasionally results in rendering a blob-image mask with -57 xscale applied, requiring tiling.
Jeff, did we ultimately do this? I forget how we resolved this crasher.
Flags: needinfo?(jmuizelaar)
I don't think we ever did implement this. I'm not sure how it works. Maybe nical knows.
Flags: needinfo?(jmuizelaar) → needinfo?(nical.bugzilla)
I don't know. In some cases (or all cases?) webrender rasterizes masks and then sample from that which isn't incompatible with tiled blob images I suppose.
Flags: needinfo?(nical.bugzilla)
I don't think it does work. The crashtest in comment 0 is still skipped.
Priority: P2 → P1
Assignee: nobody → bugmail
that is... surprising? Did anything change that would make enormous blob masks not allocate a ton of memory, glenn?
Flags: needinfo?(gwatson)
Not that I'm aware of, unless it's somehow impacted by the image -> brush work nical landed a few weeks ago.
Flags: needinfo?(gwatson)
Would the texture size cap in bug 1454187 have fixed it?
Ah yes, it would prevent the crash, although it wouldn't actually cause the right results. Anyway, good enough to enable the crashtest.
Comment on attachment 8985876 [details]
Bug 1435896 - Re-enable crashtest that is now passing.

https://reviewboard.mozilla.org/r/251380/#review257916
Attachment #8985876 - Flags: review?(a.beingessner) → review+
Ok, I'll clone this bug to track fixing it better.
Depends on: 1454187
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db3c96ac1e3a
Re-enable crashtest that is now passing. r=Gankro
https://hg.mozilla.org/mozilla-central/rev/db3c96ac1e3a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: