Closed
Bug 1435896
Opened 6 years ago
Closed 6 years ago
WR: Implement Tiled Blob Masks
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla62
People
(Reporter: Gankra, Assigned: kats)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
gfx/tests/crashtests/1278305.html contains an animation that occasionally results in rendering a blob-image mask with -57 xscale applied, requiring tiling.
Updated•6 years ago
|
Blocks: stage-wr-trains
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
See Also: → https://github.com/servo/webrender/issues/1611
Reporter | ||
Comment 1•6 years ago
|
||
Jeff, did we ultimately do this? I forget how we resolved this crasher.
Flags: needinfo?(jmuizelaar)
Comment 2•6 years ago
|
||
I don't think we ever did implement this. I'm not sure how it works. Maybe nical knows.
Flags: needinfo?(jmuizelaar) → needinfo?(nical.bugzilla)
Comment 3•6 years ago
|
||
I don't know. In some cases (or all cases?) webrender rasterizes masks and then sample from that which isn't incompatible with tiled blob images I suppose.
Flags: needinfo?(nical.bugzilla)
Assignee | ||
Comment 4•6 years ago
|
||
I don't think it does work. The crashtest in comment 0 is still skipped.
Assignee | ||
Updated•6 years ago
|
Priority: P2 → P1
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c476c26aee040457c1ace995989b708aa3774e61 It looks like the crashtest doesn't actually fail any more if enabled.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bugmail
Comment hidden (mozreview-request) |
Reporter | ||
Comment 7•6 years ago
|
||
that is... surprising? Did anything change that would make enormous blob masks not allocate a ton of memory, glenn?
Flags: needinfo?(gwatson)
Comment 8•6 years ago
|
||
Not that I'm aware of, unless it's somehow impacted by the image -> brush work nical landed a few weeks ago.
Flags: needinfo?(gwatson)
Assignee | ||
Comment 9•6 years ago
|
||
Would the texture size cap in bug 1454187 have fixed it?
Reporter | ||
Comment 10•6 years ago
|
||
Ah yes, it would prevent the crash, although it wouldn't actually cause the right results. Anyway, good enough to enable the crashtest.
Reporter | ||
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8985876 [details] Bug 1435896 - Re-enable crashtest that is now passing. https://reviewboard.mozilla.org/r/251380/#review257916
Attachment #8985876 -
Flags: review?(a.beingessner) → review+
Assignee | ||
Comment 12•6 years ago
|
||
Ok, I'll clone this bug to track fixing it better.
Depends on: 1454187
Comment 13•6 years ago
|
||
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db3c96ac1e3a Re-enable crashtest that is now passing. r=Gankro
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/db3c96ac1e3a
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Updated•6 years ago
|
status-firefox61:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•