Open Bug 1469565 Opened 6 years ago Updated 2 years ago

WR: Implement Tiled Blob Masks

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

Tracking Status
firefox63 --- affected

People

(Reporter: kats, Unassigned)

References

(Blocks 1 open bug)

Details

gfx/tests/crashtests/1278305.html contains an animation that occasionally results in rendering a blob-image mask with -57 xscale applied, requiring tiling.

The fix in bug 1454187 made the crashtest not crash, but according to bug 1435896 comment 10 it's going to produce incorrect results. This bug is to track fixing it better.
Per discussion with :Gankro, bug 1454187 might actually have fixed this for reals. But we should add a test at least.
Priority: P3 → P4
Kats -- is this fixed?  Is this bug now about just adding a test?  I've moved this to stage-wr-next, but please move it back if I've misunderstood something.
Blocks: stage-wr-next
No longer blocks: stage-wr-trains
Flags: needinfo?(kats)
We currently tile extremely large blob masks, but tiling is buggy/crashy when we try to enable it unconditionally, *especially for masks*, indicating more work needs to be done.
Flags: needinfo?(kats)
Based on comment 3 let's move this back to the MVP list, as tiling blobs seems to be pretty important in practice and we should make sure it's solid. Feel free to bump it back if you disagree.
Blocks: stage-wr-trains
No longer blocks: stage-wr-next
Flags: needinfo?(jmuizelaar)
Blocks: wr-67
No longer blocks: stage-wr-trains
Flags: needinfo?(jmuizelaar)
Priority: P4 → P3
Flags: needinfo?(jmuizelaar)
Blocks: wr-68
No longer blocks: wr-67
Flags: needinfo?(jmuizelaar)
Blocks: wr-70
No longer blocks: wr-68
No longer blocks: wr-70
Blocks: wr-blob-perf
See Also: → 1664060
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.