1436121 - hg outgoing is broken with firefoxtree + hg 4.5

Status: RESOLVED FIXED

(Developer Services :: Mercurial: firefoxtree, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

I can pull from inbound fine, but outgoing doesn't work. This is with an up-to-date clone of version-control-tools.

ryanvm@ubuntu:~/repos/mozilla$ hg pull inbound
pulling from inbound
searching for changes
no changes found
added 1 pushes
ryanvm@ubuntu:~/repos/mozilla$ hg out inbound
no revisions specified; using . to avoid inspecting multiple heads
abort: repository inbound does not exist!

Comment 1

[Tom Prince [:tomprince]]

This is probably due to https://www.mercurial-scm.org/repo/hg/rev/0ebd94ac56d1

Comment 2

[Tom Prince [:tomprince]]

It looks like either hg upstream needs to be changed, or firefoxtree changed to extend `ui.paths.getpath`.

Comment 3

[Gregory Szorc [:gps]]

firefoxtree should define paths more properly. The way it works today is somewhat hacky. I think it should inject fake config options to define the [paths] entries for each Firefox repo.

Comment 4

[Gregory Szorc [:gps]]

Attachment: firefoxtree: remove old code to support pre-3.8;

We require support for Mercurial 4.1. Remove this old compatibility
code.

Review commit: https://reviewboard.mozilla.org/r/225812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225812/

Comment 5

[Gregory Szorc [:gps]]

Attachment: firefoxtree: update URI for `hg outgoing` (bug 1436121);

We replace the `dest` argument in pushcommand(). We do the same for
our wrapped `hg outgoing` command handler. This makes Mercurial 4.5
happy because that version takes a slightly different code path for
resolving names.

This fixes the test failure in test-push-limit-revs.t on 4.5 for
`hg outgoing`. The command output is slightly different, but that's
OK.

Review commit: https://reviewboard.mozilla.org/r/225814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225814/

Comment 6

[Gregory Szorc [:gps]]

Attachment: firefoxtree: document divergence from Mercurial behavior;

While we're here, let's document that our behavior for choosing the
outgoing URL diverges from Mercurial's.

Review commit: https://reviewboard.mozilla.org/r/225816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/225816/

Comment 7

[Connor Sheehan [:sheehan]]

Comment on attachment 8956865 [details]
firefoxtree: remove old code to support pre-3.8;

https://reviewboard.mozilla.org/r/225812/#review231698

Comment 8

[Connor Sheehan [:sheehan]]

Comment on attachment 8956866 [details]
firefoxtree: update URI for `hg outgoing` (bug 1436121);

https://reviewboard.mozilla.org/r/225814/#review231706

Comment 9

[Connor Sheehan [:sheehan]]

Comment on attachment 8956867 [details]
firefoxtree: document divergence from Mercurial behavior;

https://reviewboard.mozilla.org/r/225816/#review231710

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/88418a1f9370
firefoxtree: update URI for `hg outgoing` ; r=sheehan