Closed
Bug 1436342
Opened 6 years ago
Closed 6 years ago
Pick better access keys for intl.regional_prefs.use_os_locales UI
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird59 fixed, thunderbird60 fixed)
RESOLVED
FIXED
Thunderbird 60.0
People
(Reporter: rsx11m.pub, Assigned: rsx11m.pub)
References
Details
Attachments
(1 file)
2.57 KB,
patch
|
Paenglab
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1384007 +++ > # LOCALIZATION NOTE (appLocaleString): %S = Name of the application locale, > # e.g. English (United States) > appLocale.label=Application locale: %S > appLocale.accesskey=p > # LOCALIZATION NOTE (rsLocaleString): %S = Name of the locale chosen in regional settings, > # e.g. German (Germany) > rsLocale.label=Regional settings locale: %S > rsLocale.accesskey=g Two issues here: 1. LOCALIZATION NOTE (*String) references should be LOCALIZATION NOTE (*.label) 2. the 'p' and 'g' access keys don't look very good, the characters reach into the '_' The first is trivial, for the second I'd suggest: - Change access key for "Enable Global Search and Indexer" to 'G' - this frees up the 'e' for "Regional settings locale" - switch "Application locale" from 'p' to 'o' There is 'O' used in the Offline settings, but those are in a different tab and shouldn't interfere.
Not reving any IDs as this is an en-US only change without modifying semantics.
Attachment #8948980 -
Flags: review?(richard.marti)
Comment 2•6 years ago
|
||
Comment on attachment 8948980 [details] [diff] [review] Proposed patch Looks good, thanks.
Attachment #8948980 -
Flags: review?(richard.marti) → review+
Keywords: checkin-needed
Comment on attachment 8948980 [details] [diff] [review] Proposed patch Thanks for the review. This patch may be suitable for comm-beta to give this more exposure in an additional pre-release, given that only en-US strings were changed. [Approval Request Comment] Regression caused by (bug #): follow-up to bug 1384007 User impact if declined: none Testing completed (on c-c, etc.): works on trunk Risk to taking this patch (and alternatives if risky): none
Attachment #8948980 -
Flags: approval-comm-beta?
Comment 4•6 years ago
|
||
Comment on attachment 8948980 [details] [diff] [review] Proposed patch Thanks.
Attachment #8948980 -
Flags: approval-comm-beta? → approval-comm-beta+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/0ef2fab5b6fb Pick better access keys for intl.regional_prefs.use_os_locales UI. r=Paenglab
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 60.0
Comment 6•6 years ago
|
||
Beta (TB 59): https://hg.mozilla.org/releases/comm-beta/rev/5531b31dc93b4fd8b892e5c8f37fb66339781c59
status-thunderbird59:
--- → fixed
status-thunderbird60:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•