1436342 - Pick better access keys for intl.regional_prefs.use_os_locales UI

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[rsx11m]

+++ This bug was initially created as a clone of Bug #1384007 +++

> # LOCALIZATION NOTE (appLocaleString): %S = Name of the application locale,
> # e.g. English (United States)
> appLocale.label=Application locale: %S
> appLocale.accesskey=p
> # LOCALIZATION NOTE (rsLocaleString): %S = Name of the locale chosen in regional settings,
> # e.g. German (Germany)
> rsLocale.label=Regional settings locale: %S
> rsLocale.accesskey=g

Two issues here:
 1. LOCALIZATION NOTE (*String) references should be LOCALIZATION NOTE (*.label)
 2. the 'p' and 'g' access keys don't look very good, the characters reach into the '_'

The first is trivial, for the second I'd suggest:
 - Change access key for "Enable Global Search and Indexer" to 'G'
 - this frees up the 'e' for "Regional settings locale"
 - switch "Application locale" from 'p' to 'o'

There is 'O' used in the Offline settings, but those are in a different tab and shouldn't interfere.

Comment 1

[rsx11m]

Attachment: Proposed patch

Not reving any IDs as this is an en-US only change without modifying semantics.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 8948980 [details] [diff] [review]
Proposed patch

Looks good, thanks.

Comment 3

[rsx11m]

Comment on attachment 8948980 [details] [diff] [review]
Proposed patch

Thanks for the review. This patch may be suitable for comm-beta to give this more exposure in an additional pre-release, given that only en-US strings were changed.

[Approval Request Comment]
Regression caused by (bug #): follow-up to bug 1384007
User impact if declined: none
Testing completed (on c-c, etc.): works on trunk
Risk to taking this patch (and alternatives if risky): none

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8948980 [details] [diff] [review]
Proposed patch

Thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0ef2fab5b6fb
Pick better access keys for intl.regional_prefs.use_os_locales UI. r=Paenglab

Comment 6

[Jorg K (CEST = GMT+2)]

Beta (TB 59):
https://hg.mozilla.org/releases/comm-beta/rev/5531b31dc93b4fd8b892e5c8f37fb66339781c59