1436473 - Web Authentication - rename MakePublicKeyCredentialOptions dict to PublicKeyCredentialCreationOptions

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/they)]

Late-changing rename.

Comment 1

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1436473 - Rename WebAuthn dict to PublicKeyCredentialCreationOptions

Late-breaking rename pre-CR in Web Authentication [1] renamed a dictionary. It's
not an interop issue, really, which must be why it was let through. This is a
WebIDL and Web Platform Tests-only issue. (The WPT updates are happening at
Github [2])

[1] https://github.com/w3c/webauthn/pull/779/files
[2] https://github.com/w3c/web-platform-tests/pull/9237

Review commit: https://reviewboard.mozilla.org/r/218520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218520/

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8949120 [details]
Bug 1436473 - Rename WebAuthn dict to PublicKeyCredentialCreationOptions

https://reviewboard.mozilla.org/r/218520/#review224310

Comment 3

[J.C. Jones [:jcj] (he/they)]

Thanks, Baku!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8228ef851efd
Rename WebAuthn dict to PublicKeyCredentialCreationOptions r=baku

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8228ef851efd

Comment 6

[Chris Mills [:cmills]]

I've documented this:

References in the reference docs updated:
https://developer.mozilla.org/en-US/docs/Web/API/Web_Authentication_API
https://developer.mozilla.org/en-US/docs/Web/API/CredentialsContainer/create
https://developer.mozilla.org/en-US/docs/Web/API/PublicKeyCredentialCreationOptions

Note that some of this will look a bit unfinished — Adam Powers is currently in the middle of documenting the API as a whole.

Notes added to Fx60 rel notes:
https://developer.mozilla.org/en-US/Firefox/Releases/60#DOM