Closed Bug 1436488 Opened 7 years ago Closed 7 years ago

Move window related functions into calWindowUtils.jsm

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Version:
Lightning 6.2
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(2 files, 3 obsolete files)

Automatic Changes - v1
14.89 KB, patch
Details | Diff | Splinter Review
Manual Changes - v4
10.57 KB, patch
MakeMyDay
: review+
Details | Diff | Splinter Review
Using the script from attachment 8942466 [details] [diff] [review] and the following migrations: cal.openCalendarWizard -> cal.window.openCalendarWizard cal.openCalendarProperties -> cal.window.openCalendarProperties cal.calPrint -> cal.window.openPrintDialog cal.getCalendarWindow -> cal.window.getCalendarWindow I'd like to move window functions out of calUtils.js(m). Again, there will be some manual changes in one patch, and one with all automatic changes. This goes after bug 1433802 in patch order.
Attached patch Manual Changes - v1 (obsolete) — — Splinter Review
Attachment #8949134 - Flags: review?(makemyday)
You didn't include calWindowUtils.jsm in the patch - is this intended?
Attached patch Manual Changes - v2 (obsolete) — — Splinter Review
Not at all, thanks!
Attachment #8949134 - Attachment is obsolete: true
Attachment #8949134 - Flags: review?(makemyday)
Attachment #8949170 - Flags: review?(makemyday)
Attached patch Manual Changes - v3 (obsolete) — — Splinter Review
Attachment #8949170 - Attachment is obsolete: true
Attachment #8949170 - Flags: review?(makemyday)
Attachment #8949207 - Flags: review?(makemyday)
This is the patch I used on try.
Attachment #8949207 - Attachment is obsolete: true
Attachment #8949207 - Flags: review?(makemyday)
Attachment #8949341 - Flags: review?(makemyday)
Comment on attachment 8949341 [details] [diff] [review] Manual Changes - v4 Review of attachment 8949341 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=me
Attachment #8949341 - Flags: review?(makemyday) → review+
Please push both the automatic and manual patches.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/6101dbce66cc Move window related functions into calWindowUtils.jsm - manual changes. r=MakeMyDay https://hg.mozilla.org/comm-central/rev/1fad79cf6e7f Move window related functions into calWindowUtils.jsm - automatic changes. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: