1437374 - Scrolling on a drop-down menu shows blank areas with retain-dl

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P2)

Description

[Mayank Bansal]

Attachment: bandicam 2018-02-11 19-15-58-348.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180211100408

Steps to reproduce:

1. Create fresh nightly profile
2. Go to https://www.spectra.co/broadband-plans-in-pune
3. choose "Select your area" as "Wakad" from the dropdown
4. In the "select your society" dropdown, drag the vertical scrollbar up and down.


Actual results:

parts of the list disappears for a few seconds or flashes


Expected results:

not so

Mozregresion gave me: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a20dc29e502d8b74a1fca9195154d895d7de9ec0&tochange=3403b5f669d1395097f26c69c514e52d302a3ec0

2018-02-11T19:13:57: DEBUG : Using url: https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=3403b5f669d1395097f26c69c514e52d302a3ec0&full=1
2018-02-11T19:13:59: DEBUG : Found commit message:
Bug 1436189 - Part 2: Make sure we descend to the modified frame so that we descend through the containing block and mark out of flow frames for display. r=miko

2018-02-11T19:13:59: INFO : The bisection is done.
2018-02-11T19:13:59: INFO : Stopped


If I disable retain-dl, then this does not reproduce.

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

I can repo this, setting to NEW

Comment 2

[Matt Woodrow (:mattwoodrow)]

Regressed by https://hg.mozilla.org/integration/mozilla-inbound/rev/24cf388d5d5b

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Don't intersect with the overflow rect if we're taking the displayport into account

If FrameHasDisplayport == true, then the current frame is the outer scroll frame, and the overflow rect will be clipped to the scrollport.

The branch below this code handles clipping the dirty rect to the displayport area, so we don't want to clip to the overflow.

Reftest does an invalidation outside of the scrollport, but within the displayport to check that we correctly handle invalidations in that area.

I needed reftest-snapshot-all since the code that figures out which part of the canvas to snapshot runs on the client side, and doesn't take the async scroll position into account.

Comment 5

[Miko Mynttinen]

Comment on attachment 8950123 [details] [diff] [review]
Don't intersect with the overflow rect if we're taking the displayport into account

Review of attachment 8950123 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7953b08f4886
Don't intersect the rebuild rect with the frame's overflow area if we're about to take the displayport into account. r=miko

Comment 7

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 7953b08f4886 (bug 1437374) for reftest failures at reftest/tests/layout/reftests/display-list/1437374-1.html

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=7953b08f4886fe4fc18f07423e0ba059ffb20b78

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=162251064&repo=mozilla-inbound&lineNumber=22245

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/de9ee841daffadd0d0c0237ee8d8db743ed17867

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8eeddf07480
Don't intersect the rebuild rect with the frame's overflow area if we're about to take the displayport into account. r=miko

Comment 9

[Andrei Ciure[:aciure]]

Backed out changeset b8eeddf07480 (bug 1437374) for failing builds/worker/workspace/build/tests/reftest/tests/layout/reftests/display-list/1437374-1.html a=backout on a CLOSED TREE

push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b8eeddf074805dd9657eba62349f53f47ae4bbc8

failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&fromchange=d60680f8627c01e89e4a6356b0aee1cd1e733bce&selectedJob=162352366&filter-searchStr=Linux%20debug%20Reftests%20test-linux32%2Fdebug-reftest-8%20R(R8)

https://treeherder.mozilla.org/logviewer.html#?job_id=162352366&repo=mozilla-inbound&lineNumber=22282

backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/233264cbd1693ca54bbe70e28e54acedb7b822cc

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a15c2c921d8
Don't intersect the rebuild rect with the frame's overflow area if we're about to take the displayport into account. r=miko

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8a15c2c921d8

Comment 14

[Itiel]

Symptoms described at bug 1438621 seems to be fixed after this has landed.