Closed Bug 1437473 Opened 4 years ago Closed 4 years ago

Turn off funsize caching for tiny files

Categories

(Release Engineering :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
Tracking Status
firefox60 --- fixed

People

(Reporter: sfraser, Assigned: sfraser)

References

Details

Attachments

(1 file)

We don't get a performance increase by caching small files in S3, as the time taken to check the file is present and fetch it is longer than recalculating the diff. 

If we filter out files less than 1Mb or so, we'll avoid a lot of this.
Comment on attachment 8950162 [details]
Bug 1437473 Don't cache smaller partials diffs

https://reviewboard.mozilla.org/r/219422/#review225148

LGTM, smart profiling!
Attachment #8950162 - Flags: review?(mtabara) → review+
Trying out ~500k threshold to start with
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9842bab5fcf8
Don't cache smaller partials diffs r=mtabara
https://hg.mozilla.org/mozilla-central/rev/9842bab5fcf8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Component: General Automation → General
Assignee: nobody → sfraser
You need to log in before you can comment on or make changes to this bug.