Closed
Bug 1437473
Opened 8 years ago
Closed 8 years ago
Turn off funsize caching for tiny files
Categories
(Release Engineering :: General, enhancement)
Release Engineering
General
Tracking
(firefox60 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: sfraser, Assigned: sfraser)
References
Details
Attachments
(1 file)
We don't get a performance increase by caching small files in S3, as the time taken to check the file is present and fetch it is longer than recalculating the diff.
If we filter out files less than 1Mb or so, we'll avoid a lot of this.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8950162 [details]
Bug 1437473 Don't cache smaller partials diffs
https://reviewboard.mozilla.org/r/219422/#review225148
LGTM, smart profiling!
Attachment #8950162 -
Flags: review?(mtabara) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Trying out ~500k threshold to start with
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9842bab5fcf8
Don't cache smaller partials diffs r=mtabara
|
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
|
||
Updated•8 years ago
|
Component: General Automation → General
|
||
Updated•8 years ago
|
Assignee: nobody → sfraser
You need to log in
before you can comment on or make changes to this bug.
Description
•