1437620 - webrender incorrectly claims to implement text-combine: upright

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Aria Beingessner [:Gankra]]

This CSS feature basically says "here's a substring that shouldn't ever be line-broken or otherwise overflow in vertical text; squash it horizontally if you must.

We should either fallback or implement the feature properly.

This is seems kinda niche: seemingly only used for longer arabic numbers (123456) in vertical text, but perhaps that's *most* numbers in CJ text? I expect it will be fine to fallback here, and expect to do so unless I discover it's very easy to teach webrender about this (would be very surprised).

Comment 1

[Aria Beingessner [:Gankra]]

This is causing the following two failures:

== css-writing-modes/text-combine-upright-value-all-002.html css-writing-modes/reference/vertical-ahem-1x1-ref.html
== css-writing-modes/text-combine-upright-value-all-003.html css-writing-modes/reference/vertical-ahem-1x1-ref.html

Comment 2

[Aria Beingessner [:Gankra]]

Attachment: Bug 1437620 - Webrender: fallback on non-trivial text-combine-uprights.

Review commit: https://reviewboard.mozilla.org/r/220526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220526/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8951270 [details]
Bug 1437620 - Webrender: fallback on non-trivial text-combine-uprights.

https://reviewboard.mozilla.org/r/220526/#review226492

Comment 4

[Aria Beingessner [:Gankra]]

try: tests now pass :D

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8996c40d5b3deea9fb5bd01aa57615d9444bc3f&selectedJob=162440058

Comment 5

[Aria Beingessner [:Gankra]]

Attachment: Bug 1437620 - mark tests as newly passing under wr.

Review commit: https://reviewboard.mozilla.org/r/220592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220592/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8951346 [details]
Bug 1437620 - mark tests as newly passing under wr.

https://reviewboard.mozilla.org/r/220592/#review226606

yay!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48056396963a
Webrender: fallback on non-trivial text-combine-uprights. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/7c9182876dfd
mark tests as newly passing under wr. r=kats

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/48056396963a
https://hg.mozilla.org/mozilla-central/rev/7c9182876dfd