1497589 - Extend flexbox devtools API to return the physical directions of the axes

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, enhancement, P3)

Description

[Daniel Holbert [:dholbert]]

Per bug 1497182 comment 5, let's extend the devtools flexbox API to provide information about the physical direction of the flex main/cross axes, so that devtools JS doesn't have to figure that out on its own from CSS 'direction', 'writing-mode', & flex-{direction,wrap}:*-reverse (each of which can mess with the axes).

Comment 1

[Brad Werth [:bradwerth]]

I'm happy to take this on if that's helpful.

Comment 2

[Daniel Holbert [:dholbert]]

Sure, that'd be great -- thanks!

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1497589 Part 3: Stub in physical direction enums for Flex API main and cross axes. r=dholbert!

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1497589 Part 4: Set ComputedFlexContainerInfo physical axis values, and expose them through the Flex API. r=dholbert!

Depends on D8616

Comment 5

[Brad Werth [:bradwerth]]

Attachment: Bug 1497589 Part 5: Add tests of Flex mainAxisDirection and crossAxisDirection. r=dholbert!

Depends on D8617

Comment 6

[Brad Werth [:bradwerth]]

Attachment: Bug 1497589 Part 1: Move Flex.webidl to the chrome-webidl directory.

Comment 7

[Brad Werth [:bradwerth]]

Attachment: Bug 1497589 Part 2: Rename Flex API classes to avoid namespace collision with nsFlexContainerFrame classes.

Depends on D9022

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c597d36a2d7a
Part 1: Move Flex.webidl to the chrome-webidl directory. r=bzbarsky,dholbert
https://hg.mozilla.org/integration/autoland/rev/d0b82fc9252d
Part 2: Rename Flex API classes to avoid namespace collision with nsFlexContainerFrame classes. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/082aaca611f9
Part 3: Stub in physical direction enums for Flex API main and cross axes. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/d8e73cf6952f
Part 4: Set ComputedFlexContainerInfo physical axis values, and expose them through the Flex API. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/49e1cc5fdf49
Part 5: Add tests of Flex mainAxisDirection and crossAxisDirection. r=dholbert

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c597d36a2d7a
https://hg.mozilla.org/mozilla-central/rev/d0b82fc9252d
https://hg.mozilla.org/mozilla-central/rev/082aaca611f9
https://hg.mozilla.org/mozilla-central/rev/d8e73cf6952f
https://hg.mozilla.org/mozilla-central/rev/49e1cc5fdf49

Comment 10

[Chris Mills [:cmills]]

removing DDN; this on its own is not enough to warrant documenting the feature. We'll follow the "enable in 
Nightly" bug instead.