Closed Bug 1497589 Opened 11 months ago Closed 10 months ago

Extend flexbox devtools API to return the physical directions of the axes

Categories

(Core :: Layout: Flexbox, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: dholbert, Assigned: bradwerth)

References

Details

Attachments

(5 files)

Per bug 1497182 comment 5, let's extend the devtools flexbox API to provide information about the physical direction of the flex main/cross axes, so that devtools JS doesn't have to figure that out on its own from CSS 'direction', 'writing-mode', & flex-{direction,wrap}:*-reverse (each of which can mess with the axes).
I'm happy to take this on if that's helpful.
Sure, that'd be great -- thanks!
Assignee: dholbert → bwerth
Attachment #9016834 - Attachment description: Bug 1497589 Part 1: Stub in physical direction enums for Flex API main and cross axes. r=dholbert! → Bug 1497589 Part 3: Stub in physical direction enums for Flex API main and cross axes. r=dholbert!
Attachment #9016835 - Attachment description: Bug 1497589 Part 2: Set ComputedFlexContainerInfo physical axis values, and expose them through the Flex API. r=dholbert! → Bug 1497589 Part 4: Set ComputedFlexContainerInfo physical axis values, and expose them through the Flex API. r=dholbert!
Attachment #9016836 - Attachment description: Bug 1497589 Part 3: Add tests of Flex mainAxisDirection and crossAxisDirection. r=dholbert! → Bug 1497589 Part 5: Add tests of Flex mainAxisDirection and crossAxisDirection. r=dholbert!
Blocks: 1488885
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c597d36a2d7a
Part 1: Move Flex.webidl to the chrome-webidl directory. r=bzbarsky,dholbert
https://hg.mozilla.org/integration/autoland/rev/d0b82fc9252d
Part 2: Rename Flex API classes to avoid namespace collision with nsFlexContainerFrame classes. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/082aaca611f9
Part 3: Stub in physical direction enums for Flex API main and cross axes. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/d8e73cf6952f
Part 4: Set ComputedFlexContainerInfo physical axis values, and expose them through the Flex API. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/49e1cc5fdf49
Part 5: Add tests of Flex mainAxisDirection and crossAxisDirection. r=dholbert
removing DDN; this on its own is not enough to warrant documenting the feature. We'll follow the "enable in 
Nightly" bug instead.
You need to log in before you can comment on or make changes to this bug.