1437647 - Firefox window is always restored not maximized, also if it was maximized in the previous session

Status: RESOLVED DUPLICATE of bug 1460639

(Firefox :: Session Restore, defect, P3)

Description

[Marco Castelluccio [:marco]]

The Firefox window is always restored not maximized for me, also if I always maximize it in my sessions.

Comment 1

[Mike de Boer [:mikedeboer]]

Which OS are you seeing this on and which browser version?

It'd be good to see if QE can reproduce this once we have that info.

Comment 2

[Marco Castelluccio [:marco]]

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> Which OS are you seeing this on and which browser version?
> 
> It'd be good to see if QE can reproduce this once we have that info.

Linux (Ubuntu 17.10) with Nightly, but I've been seeing this for a while.

I can't reproduce in a clean profile.

Comment 3

[Andrew Overholt [:overholt]]

(In reply to Marco Castelluccio [:marco] from comment #2)
> I can't reproduce in a clean profile.

Is there a way to bisect your prefs?

Comment 4

[Marco Castelluccio [:marco]]

Attachment: aboutsupport.txt

(In reply to Andrew Overholt [:overholt] from comment #3)
> (In reply to Marco Castelluccio [:marco] from comment #2)
> > I can't reproduce in a clean profile.
> 
> Is there a way to bisect your prefs?

I've never heard of any automated way to do it, I would be happy if there was.

I'm attaching my about:support.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Schermata da 2018-02-15 02-11-35.png

I've noticed sometimes weird things happen in a clean profile too. I'm not sure if the they are the same bug.

Comment 7

[Jason]

I'm having (I believe) the same issue in Firefox 61 (2018-03-17 64-bit) on Windows 10 1709 Enterprise.

To reproduce:

1. Delete AppData\Local\Mozilla and AppData\Roaming\Mozilla to get a clean profile.
2. Open Firefox.
3. Maximize the Firefox window.
4. Close Firefox.
5. Open Firefox again.  The window will be restored, not maximized.


Settings that probably don't matter:

Resolution: 1920x1980
DPI: 150%
Windows user account is standard user, not admin

Comment 8

[Jason]

Interesting: it *does* remember the size of the window from your last session so long as the size of the window was not maximized.  The only window size that it will not remember from a previous session is a maximized window.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Note that Nightly had a similar bug filed against it more recently (bug 1446264), which is probably what comments 7-8 were seeing).

Marco, are you still seeing this?

Comment 10

[Marco Castelluccio [:marco]]

Yes, still happening. This is a much older regression.

Comment 11

[Gabriele Svelto [:gsvelto]]

I'm also seeing this with today's local build. My STR is:

1. Resize Firefox window in any non-maximized mode
2. Maximize the window
3. Close Firefox
4. Restart Firefox

The window is opened as maximized but the contents of the window (including the UI controls) are the size of the non-maximized window I set previously.

Something similar already happened in the past, when launching I could see the non-maximized version of the window contents for a split-second and then the contents would be repainted to fill the maximized window.

Comment 12

[Gabriele Svelto [:gsvelto]]

BTW last week this wasn't happening, I can run a bisection if nobody else is doing it yet.

Comment 13

[Marco Castelluccio [:marco]]

(In reply to Gabriele Svelto [:gsvelto] from comment #12)
> BTW last week this wasn't happening, I can run a bisection if nobody else is
> doing it yet.

Sure, a bisection would be helpful, but if it started only recently it might be a different bug (as I've been experiencing this for a while).

Comment 14

[Gabriele Svelto [:gsvelto]]

FYI I'm running the bisection right now.

Comment 15

[Gabriele Svelto [:gsvelto]]

Alright, sorry this took a while, the issue was introduced by bug 1453788.

Comment 16

[Gabriele Svelto [:gsvelto]]

Brendan, this issue seems to have been introduced by your patch. I had a quick look but I'm not familiar with that code so you're probably the best person to debug this. What seems to be happening is that the size of the inner window does not match that of the outer window once it's maximized. Additionally, when the window is first created it's not maximized, it gets maximized later but the contents are not resized.