1460639 - Mozilla Firefox Nightly 62.0a1 (2018-05-10) always starts in windowed/non-maximized mode

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Pizzapops]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180510100205

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Looking on Mozilla Firefox Nightly 62.0a1 (2018-05-10) daily pushlog,
these bugs seems most suspicious:
- Bug 1453788 - Remember window size and location for chrome HTML windows
- Bug 1460116 - Remove ShouldHideScrollbars
- Bug 1457338 - Tap in tab strip stops mouse drags

or it's missed call?

Comment 3

[Brendan Dahl [:bdahl]]

Pretty sure this is from my patch, I'll look into it.

Comment 4

[Timea Cernea [:tbabos][inactive]]

After manually testing the issue I found the following: 

Last good version: Nightly 62.0a1 – Build ID: 20180509100510 – (2018-05-09)
First bad version: Nightly 62.0a1 – Build ID:  20180510100205 – (2018-05-10)

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Timea Babos from comment #4)
> After manually testing the issue I found the following: 
> 
> Last good version: Nightly 62.0a1 – Build ID: 20180509100510 – (2018-05-09)
> First bad version: Nightly 62.0a1 – Build ID:  20180510100205 – (2018-05-10)

Good, but this is already written in bug summary ;)

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Since this has an assignee and we'll see it in regression triage, I don't think we need to specially track it.

Comment 7

[Brendan Dahl [:bdahl]]

Attachment: Bug 1460639 - Apply persisted window settings before layout.

Previously, with early first paint enabled, nsXULWindow incorrectly loaded the
persisted window settings from about:blank and would only load them once.
Instead, load the settings before starting layout.

Review commit: https://reviewboard.mozilla.org/r/244712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244712/

Comment 8

[Brendan Dahl [:bdahl]]

I'm also working on a test, but running into intermittent failures do to the way persist values are stored on a timer.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8976629 [details]
Bug 1460639 - Apply persisted window settings before layout.

https://reviewboard.mozilla.org/r/244712/#review250844

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

this code seems to be very regression prone, so it would be great to get some good tests.

Comment 12

[Brendan Dahl [:bdahl]]

Attachment: Bug 1460639 - Add test for loading persisted size of a navigated window.

Review commit: https://reviewboard.mozilla.org/r/245926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245926/

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8979778 [details]
Bug 1460639 - Add test for loading persisted size of a navigated window.

https://reviewboard.mozilla.org/r/245926/#review252392

::: toolkit/content/tests/chrome/test_navigate_persist.html:42
(Diff revision 1)
> +      win.resizeTo(size, size);
> +      return resizePromise;
> +    }
> +
> +    async function runTest() {
> +      // Test that the persisted window attributes are loaded for browser.xul

I don't understand this comment. I don't see browser.xul being loaded anywhere.
I assume you mean window_navigate_persist.html

Comment 16

[Brendan Dahl [:bdahl]]

Comment on attachment 8979778 [details]
Bug 1460639 - Add test for loading persisted size of a navigated window.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245926/diff/1-2/

Comment 17

[Brendan Dahl [:bdahl]]

Comment on attachment 8979778 [details]
Bug 1460639 - Add test for loading persisted size of a navigated window.

https://reviewboard.mozilla.org/r/245926/#review252606

::: toolkit/content/tests/chrome/test_navigate_persist.html:42
(Diff revision 1)
> +      win.resizeTo(size, size);
> +      return resizePromise;
> +    }
> +
> +    async function runTest() {
> +      // Test that the persisted window attributes are loaded for browser.xul

I meant for the comment to overall describe what we're trying to test. I've updated it to clarify.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4850c54a299a
Apply persisted window settings before layout. r=smaug
https://hg.mozilla.org/integration/autoland/rev/083bcc5bdad3
Add test for loading persisted size of a navigated window. r=smaug

Comment 19

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4850c54a299a
https://hg.mozilla.org/mozilla-central/rev/083bcc5bdad3

Comment 20

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 62.0a1 (2018-05-25), so I'm marking this bug as VERIFIED. Thank you very much! \o/

Comment 21

[Florent]

I have always the problem with last version 62.0a1 (2018-05-24) (64-bit) Xubuntu 18.04 LTS x64
Problem not fixed

Comment 22

[Marat Tanalin]

(In reply to comment #21)
> I have always the problem with last version 62.0a1 (2018-05-24)

The lastest build is 2018-05-26. If Nightly cannot update itself, download manually here:

http://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central/

Comment 23

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Florent from comment #21)
> I have always the problem with last version 62.0a1 (2018-05-24) (64-bit)
> Xubuntu 18.04 LTS x64
> Problem not fixed

If you would read my comment #20, you will understand properly that this bug:
- is fixed starting in Mozilla Firefox Nightly 62.0a1 (2018-05-25)
- is not fixed in in Mozilla Firefox Nightly 62.0a1 (2018-05-24).

Comment 24

[Florent]

Sorry i thinked my Nightly have been updated.

Repository  http://ppa.launchpad.net/ubuntu-mozilla-daily/ppa/ubuntu is not update with the the last version