Closed Bug 1437655 Opened 2 years ago Closed 2 years ago
Rule Node .cpp:2886:10: warning: 'return' will never be executed [-Wunreachable-code-return]
59 bytes, text/x-review-board-request
Noticed this when building locally (with clang 7.0 and unified-mode mode turned off, which might be necessary for this warning to be triggered -- not sure): ==== layout/style/nsRuleNode.cpp:2886:10: warning: 'return' will never be executed [-Wunreachable-code-return] ==== This warning is for an unreachable "return nullptr" statement, which comes after a "switch" block that returns from all of its cases (including a default case). So indeed, this line is unreachable. This issue goes back to bug 454475, which is where we added the default case.
Comment on attachment 8950347 [details] Bug 1437655: Remove unreachable "return" statement in nsRuleNode::SetDefaultOnRoot. https://reviewboard.mozilla.org/r/219574/#review225368
Attachment #8950347 - Flags: review?(bwerth) → review+
Thanks for the review!
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/850a68535455 Remove unreachable "return" statement in nsRuleNode::SetDefaultOnRoot. r=bradwerth
You need to log in before you can comment on or make changes to this bug.