1437806 - Enable browser_console.js in new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1437806 - Enable browser_console.js in new frontend

Not a huge amount needed changing in this one... changed paths, removed references to bug numbers, switched to async / await and used the new method to check for messages.

Review commit: https://reviewboard.mozilla.org/r/224676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224676/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8955522 [details]
Bug 1437806 - Enable browser_console.js in new frontend

https://reviewboard.mozilla.org/r/224676/#review230710

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console.js:99
(Diff revision 1)
>    };
>    xhrErr.open("get", TEST_XHR_ERROR_URI, true);
>    xhrErr.send();
>  
>    // Check that Fetch requests are categorized as "XHR".
> -  fetch(TEST_IMAGE).then(() => { console.log("fetch loaded"); });
> +  fetch(TEST_IMAGE).then(() => {

Can you use await instead of .then()?

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8955522 [details]
Bug 1437806 - Enable browser_console.js in new frontend

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224676/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/766cdcc88653
Enable browser_console.js in new frontend r=bgrins

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/766cdcc88653