1438060 - Remove unused /push/revisions/ API

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, enhancement, P1)

Description

[Ed Morley [:emorley]]

New Relic says `PushViewSet.revisions` hasn't been accessed once in the last 7 days:
https://rpm.newrelic.com/accounts/677903/applications/14179757/transactions/table?type=app

The only place in the UI that used to reference it:
(a) appears to never get called, since the push API always returned the revisions (think we never got around to implementing it skipping the revisions if they weren't being shown)
(b) has just been removed here: https://github.com/mozilla/treeherder/commit/f40f3faae74c02ba88a1ceefc1675dc1a7f969c2#diff-9da180a71af78c18a9d5089198b6099fL865

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3225

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8950813 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3225

It's scary how this is the 4th API removal PR in a row now, where zero tests had to be modified or removed. Least hopefully we have slightly less untested code now :-)

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8950813 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3225

Wow, yeah.  Thanks for doing all this cleanup.  We clearly have lots of "cruft" hanging around.  Though you're making quick work of cleaning it out.  :)

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d0d42ddf7e83af88a2f3011236c0b2f26732fce3
Bug 1438060 - Remove unused /push/revisions/ API (#3225)

Since revision details are included in the response from the `/push/`
API, so there's never any need to fetch them separately.

(And if anyone wants more than the first 20 commits, they should be
using hg.mozilla.org's API instead.)