Closed
Bug 1437078
Opened 8 years ago
Closed 7 years ago
Audit APIs for any that are unused and can be removed
Categories
(Tree Management :: Treeherder: API, enhancement, P1)
Tree Management
Treeherder: API
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
(Blocks 1 open bug)
Details
New Relic makes it pretty easy to see which django-rest-framework APIs are in use, via:
https://rpm.newrelic.com/accounts/677903/applications/14179757/transactions/table?type=app#sort=0%2C0
We should have a quick check to see if there is anything that is not being used.
Assignee | ||
Comment 1•8 years ago
|
||
In the last 7 days the following were not used:
* JobsViewSet.update_state
* JobsViewSet.failure_lines
* PushViewSet.revisions
* SetaFailuresFixedByCommit
* SetaJobTypes
* BuildPlatformViewSet
* MachineViewSet
* ProductViewSet
* JobGroupViewSet (only accessed twice)
* JobTypeViewSet (only accessed twice)
* MachinePlatformViewSet (only accessed once)
* FailureLineViewSet (and ClassifiedFailureViewSet was only accessed once) - though these use a custom `ExtendedRouter` so perhaps that's breaking the stats? (Or else no-one is using the new auto-classification panel?)
Now that we have:
* graphql
* redash
* read-only replica
...I don't think we should keep endpoints that aren't providing value - particularly for models who have tens of thousands of rows and so the API requests time out anyway (eg MachineViewSet and several others above).
Assignee | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•