Enable JS modules by default for all builds

RESOLVED FIXED in Firefox 60

Status

()

Core
DOM: Core & HTML
P2
normal
RESOLVED FIXED
3 months ago
7 days ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla60
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 months ago
Created attachment 8950886 [details] [diff] [review]
enable-modules

JS module scripts were enabled by default on nightly builds just over a month ago.  There haven't been any serious bugs reported in that time, so I'd like to enable this for all builds and let the feature ride the trains.

What do you think?
Attachment #8950886 - Flags: review?(bugs)

Comment 1

3 months ago
Comment on attachment 8950886 [details] [diff] [review]
enable-modules

right, bug 1428002 enabled modules in Nightly59.
Attachment #8950886 - Flags: review?(bugs) → review+
(Assignee)

Updated

3 months ago
Keywords: dev-doc-needed

Updated

3 months ago
Priority: -- → P2
(Assignee)

Comment 2

3 months ago
Created attachment 8951237 [details] [diff] [review]
bug1438139-fix-testcases

And here's a patch to update the tests for the new default.
Attachment #8951237 - Flags: review?(bugs)

Updated

3 months ago
Attachment #8951237 - Flags: review?(bugs) → review+

Comment 3

3 months ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a425e7816bb
Enable <script type="module"> by default r=smaug

Comment 4

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9a425e7816bb
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.