1438291 - add ares-6 benchmark to talos

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

ares-6 is a benchmark we run on AWFY and we want to run it on Talos.  Right now it will be as a tier-2 which is mozilla-central and try only.  This will run like motionmark.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

one concern here is that ares6 crashes often on osx, this is seen on osx for tps at least once based on what I see in bugzilla from bug 1437425

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add ares-6 benchmark source to third_party/ in-tree

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add ares-6 as a benchmark to run in talos

this patch has the ares-6 modifications and talos/taskcluster changes.  This hasn't been tested on windows- when we run windows on taskcluster we will get motionmark job running on windows which will include ares-6.  Possibly in the future we will move this to speedometer job as this is a fast benchmark.

Comment 4

[Robert Wood [:rwood]]

Comment on attachment 8951238 [details] [diff] [review]
add ares-6 benchmark source to third_party/ in-tree

Review of attachment 8951238 [details] [diff] [review]:
-----------------------------------------------------------------

Applied patch locally and was able to run ARES-6 locally (OSX) from in-tree

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8951239 [details] [diff] [review]
add ares-6 as a benchmark to run in talos

Review of attachment 8951239 [details] [diff] [review]:
-----------------------------------------------------------------

Cool!! LGTM and works locally via ./mach talos-test --suite motionmark-e10s and via ./mach talos-test -a ARES6

Just some nits on extra spaces that were already existing in the benchmark files.

::: third_party/webkit/PerformanceTests/ARES-6/driver.js
@@ +39,4 @@
>          if (isInBrowser)
>              window[key] = this;
>      }
>      

Nit: extra spaces although they were there previously

@@ +113,1 @@
>              

nit: extra spaces although they were already there

@@ +115,5 @@
>              {
>                  return Math.exp(this._sum * (1 / this._count));
>              }
>          }
>          

Nit: extra spaces

@@ +132,5 @@
>          let numIterations = Math.min(...statses.map(stats => stats.numIterations));
>          let data = new Array(numIterations);
>          for (let i = 0; i < data.length; ++i)
>              data[i] = new Geomean();
>          

Nit: extra spaces

::: third_party/webkit/PerformanceTests/ARES-6/index.html
@@ +19,2 @@
>      <div class="swoop">&nbsp;</div>
>      

Nit: extra spaces already existing though

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f61ca44f701a
add ares-6 benchmark to tree. r=rwood
https://hg.mozilla.org/integration/mozilla-inbound/rev/0745a2d7319b
add ares-6 benchmark to talos. r=rwood

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f61ca44f701a
https://hg.mozilla.org/mozilla-central/rev/0745a2d7319b