Closed
Bug 1438291
Opened 7 years ago
Closed 7 years ago
add ares-6 benchmark to talos
Categories
(Testing :: Talos, enhancement)
Testing
Talos
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [PI:February])
Attachments
(2 files)
1.15 MB,
patch
|
rwood
:
review+
|
Details | Diff | Splinter Review |
8.50 KB,
patch
|
rwood
:
review+
|
Details | Diff | Splinter Review |
ares-6 is a benchmark we run on AWFY and we want to run it on Talos. Right now it will be as a tier-2 which is mozilla-central and try only. This will run like motionmark.
Assignee | ||
Comment 1•7 years ago
|
||
one concern here is that ares6 crashes often on osx, this is seen on osx for tps at least once based on what I see in bugzilla from bug 1437425
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
this patch has the ares-6 modifications and talos/taskcluster changes. This hasn't been tested on windows- when we run windows on taskcluster we will get motionmark job running on windows which will include ares-6. Possibly in the future we will move this to speedometer job as this is a fast benchmark.
Attachment #8951239 -
Flags: review?(rwood)
Comment 4•7 years ago
|
||
Comment on attachment 8951238 [details] [diff] [review]
add ares-6 benchmark source to third_party/ in-tree
Review of attachment 8951238 [details] [diff] [review]:
-----------------------------------------------------------------
Applied patch locally and was able to run ARES-6 locally (OSX) from in-tree
Attachment #8951238 -
Flags: review?(rwood) → review+
Comment 5•7 years ago
|
||
Comment on attachment 8951239 [details] [diff] [review]
add ares-6 as a benchmark to run in talos
Review of attachment 8951239 [details] [diff] [review]:
-----------------------------------------------------------------
Cool!! LGTM and works locally via ./mach talos-test --suite motionmark-e10s and via ./mach talos-test -a ARES6
Just some nits on extra spaces that were already existing in the benchmark files.
::: third_party/webkit/PerformanceTests/ARES-6/driver.js
@@ +39,4 @@
> if (isInBrowser)
> window[key] = this;
> }
>
Nit: extra spaces although they were there previously
@@ +113,1 @@
>
nit: extra spaces although they were already there
@@ +115,5 @@
> {
> return Math.exp(this._sum * (1 / this._count));
> }
> }
>
Nit: extra spaces
@@ +132,5 @@
> let numIterations = Math.min(...statses.map(stats => stats.numIterations));
> let data = new Array(numIterations);
> for (let i = 0; i < data.length; ++i)
> data[i] = new Geomean();
>
Nit: extra spaces
::: third_party/webkit/PerformanceTests/ARES-6/index.html
@@ +19,2 @@
> <div class="swoop"> </div>
>
Nit: extra spaces already existing though
Attachment #8951239 -
Flags: review?(rwood) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f61ca44f701a
add ares-6 benchmark to tree. r=rwood
https://hg.mozilla.org/integration/mozilla-inbound/rev/0745a2d7319b
add ares-6 benchmark to talos. r=rwood
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f61ca44f701a
https://hg.mozilla.org/mozilla-central/rev/0745a2d7319b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•