Closed
Bug 1438292
Opened 7 years ago
Closed 7 years ago
add JetStream benchmark to talos
Categories
(Testing :: Talos, enhancement)
Testing
Talos
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: jmaher, Assigned: jmaher)
References
Details
(Whiteboard: [PI:February])
Attachments
(1 file, 1 obsolete file)
10.60 KB,
patch
|
rwood
:
review+
|
Details | Diff | Splinter Review |
we run jetstream benchmark on AWFY and would like to run it on talos as a tier-2 benchmark which we run on try/mozilla-central, just like motionmark.
Assignee | ||
Comment 1•7 years ago
|
||
this depends on a 50M patch to put jetstream in-tree:
https://1drv.ms/u/s!AtgqgjhJkZQqgtVFsQEEG4F6BvfPZw
Comment 2•7 years ago
|
||
Comment on attachment 8951322 [details] [diff] [review]
add jetstream to talos
Review of attachment 8951322 [details] [diff] [review]:
-----------------------------------------------------------------
Very cool, LGTM, and applied both patches locally and runs great.
I notice that "throughput" is listed on the JetStream 1.1 test, but there's no corresponding item in talos local.json results. I'm assuming that maybe throughput is on the JetStream dashboard but they don't make it available in results maybe? r+ on confirming that "throughput" shouldn't be included in the talos results.
Attachment #8951322 -
Flags: review?(rwood) → review+
Assignee | ||
Comment 3•7 years ago
|
||
throughput and latency are categories related to the 49 subtests- the final score is a geometric mean (weighted a bit) of the 49 subtests.
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9db2b954595
add JetStream benchmark source to tree. r=rwood
https://hg.mozilla.org/integration/mozilla-inbound/rev/8508dc544f8b
add JetStream benchmark to talos. r=rwood
Comment 5•7 years ago
|
||
Backed out 2 changesets (bug 1438292) for multiple failures in /builds/worker/workspace/mozharness/mozharness/base/script.py
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8508dc544f8b56d647e076e82537f4de626db089&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&selectedJob=162528182
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=162528182&repo=mozilla-inbound&lineNumber=692
Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=142b57a7b01cd14c712d00950129344e8e5fbdae&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running
Flags: needinfo?(jmaher)
Assignee | ||
Comment 6•7 years ago
|
||
while this was backed out for infrastructure issues, we are now going to use jetstream via a tooltool artifact instead of adding 50MB to the source tree.
Flags: needinfo?(jmaher)
Comment 7•7 years ago
|
||
Well, you already landed it once and the data is forever in the repo since backouts are part of the full repo history. So if you want to land it again... ¯\_(ツ)_/¯
Assignee | ||
Comment 8•7 years ago
|
||
similar to the last patch, except this uses tooltool to download jetstream.zip. this works locally, but I think we should prioritize fixing bug 1435677 in the short term to ease the pain of running tp5, jetstream, and other webkit benchmarks locally via mach.
Attachment #8951322 -
Attachment is obsolete: true
Attachment #8953066 -
Flags: review?(rwood)
Comment 9•7 years ago
|
||
Comment on attachment 8953066 [details] [diff] [review]
add jetstream to talos
Review of attachment 8953066 [details] [diff] [review]:
-----------------------------------------------------------------
Yep LGTM and I tried it out locally on OSX, runs great
Attachment #8953066 -
Flags: review?(rwood) → review+
Comment 10•7 years ago
|
||
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f4aed8caae8
add JetStream benchmark to talos. r=rwood
Comment 11•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•