Closed Bug 1438292 Opened 7 years ago Closed 7 years ago

add JetStream benchmark to talos

Categories

(Testing :: Talos, enhancement)

enhancement
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

(Whiteboard: [PI:February])

Attachments

(1 file, 1 obsolete file)

we run jetstream benchmark on AWFY and would like to run it on talos as a tier-2 benchmark which we run on try/mozilla-central, just like motionmark.
Attached patch add jetstream to talos (obsolete) — Splinter Review
this depends on a 50M patch to put jetstream in-tree: https://1drv.ms/u/s!AtgqgjhJkZQqgtVFsQEEG4F6BvfPZw
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8951322 - Flags: review?(rwood)
Comment on attachment 8951322 [details] [diff] [review] add jetstream to talos Review of attachment 8951322 [details] [diff] [review]: ----------------------------------------------------------------- Very cool, LGTM, and applied both patches locally and runs great. I notice that "throughput" is listed on the JetStream 1.1 test, but there's no corresponding item in talos local.json results. I'm assuming that maybe throughput is on the JetStream dashboard but they don't make it available in results maybe? r+ on confirming that "throughput" shouldn't be included in the talos results.
Attachment #8951322 - Flags: review?(rwood) → review+
throughput and latency are categories related to the 49 subtests- the final score is a geometric mean (weighted a bit) of the 49 subtests.
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9db2b954595 add JetStream benchmark source to tree. r=rwood https://hg.mozilla.org/integration/mozilla-inbound/rev/8508dc544f8b add JetStream benchmark to talos. r=rwood
Depends on: 1438865
while this was backed out for infrastructure issues, we are now going to use jetstream via a tooltool artifact instead of adding 50MB to the source tree.
Flags: needinfo?(jmaher)
Well, you already landed it once and the data is forever in the repo since backouts are part of the full repo history. So if you want to land it again... ¯\_(ツ)_/¯
similar to the last patch, except this uses tooltool to download jetstream.zip. this works locally, but I think we should prioritize fixing bug 1435677 in the short term to ease the pain of running tp5, jetstream, and other webkit benchmarks locally via mach.
Attachment #8951322 - Attachment is obsolete: true
Attachment #8953066 - Flags: review?(rwood)
Comment on attachment 8953066 [details] [diff] [review] add jetstream to talos Review of attachment 8953066 [details] [diff] [review]: ----------------------------------------------------------------- Yep LGTM and I tried it out locally on OSX, runs great
Attachment #8953066 - Flags: review?(rwood) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Blocks: 1445952
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: