59 bytes, text/x-review-board-request
Since nobody is actively working on fixing the bugs affecting top German and Canadian ecommerce sites we should disable support for Form Autofill in the beta channel. It will only be enabled for the US in Beta which matches release. Nightly will stay the same with autofill available in all countries. Note that the CA/DE support would already not ride the trains to release 59 since it is guarded by an update channel check. This change is only about the beta channel. The downside is that users who have already been using the feature in Beta 59 will lose it. This plan was already discussed with Erin in https://trello.com/c/wfYJJKKx/452-form-autofill-v2#comment-5a723187b7b47b3bd6b03dc5
As part of this change I will also make RTL support Nightly-only and require that the build locale be en-US again to match what already shipped. The locale requirement is reverting part of bug 1419312.
Summary: Disable CA & DE country support for Form Autofill in Beta 59+ → Disable CA & DE country support and RTL support for Form Autofill in Beta 59+
See Also: → 1438349
Comment on attachment 8951073 [details] Bug 1438306 - Disable CA & DE country support and RTL support for Form Autofill in Beta 59+. https://reviewboard.mozilla.org/r/220322/#review226288 Talked thru this with Matt, LGTM. rs=me.
Attachment #8951073 - Flags: review?(dolske) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/8d28b9f2d0ab Disable CA & DE country support and RTL support for Form Autofill in Beta 59+. r=Dolske
Comment on attachment 8951073 [details] Bug 1438306 - Disable CA & DE country support and RTL support for Form Autofill in Beta 59+. Approval Request Comment [Feature/Bug causing the regression]: Form Autofill V2 [User impact if declined]: Only gives en-US users address autofill in 59+ release. Beta users requiring RTL or in CA/DE will get address autofill even though it's not ready to ship and it's not being actively maintained. Having those features enabled on beta confuses people about when it will ship to release (e.g. in release notes). [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Not yet [Needs manual test from QE? If yes, steps to reproduce]: Maybe testing that the address autofill feature isn't available for CA & DE using the browser.search.region pref? [List of other uplifts needed for the feature/fix]: bug 1438349 is related but can be uplifted separately. [Is the change risky?]: No [Why is the change risky/not risky?]: Disabling a feature to match the release channel [String changes made/needed]: None
Attachment #8951073 - Flags: approval-mozilla-beta?
Comment on attachment 8951073 [details] Bug 1438306 - Disable CA & DE country support and RTL support for Form Autofill in Beta 59+. Disabling Form Autofill for certain regions and also for RTL users, Beta59+
Attachment #8951073 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified that Forms Autofill Addresses are not available for DE, CA and RTL users in Beta 59.0b10 across all platforms. Tested that prefs : extensions.formautofill.supportedCountries;US and extensions.formautofill.supportRTL;false are correctly set in about:config when browser.search.countryCode; and browser.search.region; are set for the unsupported countries. Smoke tested addresses autofill enabled for US and no issues were encountered
Verified as fixed that Forms Autofill addressees are not available and that preferences extensions.formautofill.supportedCountries;US and extensions.formautofill.supportRTL;false are correctly set in Beta 60.0b6.
Re-verified on the latest 60 beta, all preferences are set correctly.
You need to log in before you can comment on or make changes to this bug.