1438470 - Port |Bug 1437654 - Drop the nsINativeTreeView pretense|

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1437654 +++

addrbook/src/nsAbView.cpp:63:12: error: no member named 'SetView' in 'nsITreeBoxObject'

The SetView() methods have gone away.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1438470.patch totally wrong, but compiles ;-) [landed in comment #2, backed out in comment #7]

Sorry about the post-landing review.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bbb96e5f8fa8
Port bug 1437654 to mailnews: Remove call to nsITreeBoxObject::SetView(). rs=bustage-fix

Comment 3

[Jorg K (CEST = GMT+2)]

Looking at bug 1437654 and https://hg.mozilla.org/mozilla-central/rev/ce006d43344b#l4.15 a little longer, this fix is most likely wrong. The calls should have been replaced with calls to mozilla::dom::TreeBoxObject::SetView().

Boris, could you please give me the snipped to replace the calls I removed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Hrm.  I thought I had checked for comm-central using SetView, but maybe searchfox not indexing builds on comm-central bit me.

The fix landed here is totally wrong.  And you can't do the "right" fix because of FakeTreeBoxObject.  I keep forgetting that abomination exists in Thunderbird.

I'll fix this on the Gecko side for now...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Bug 1438512 tracks the right fix.

The "temporary fix" landed here is really really bad, fwiw: it will lead to dangling pointers and probably-exploitable crashes.  It would almost be better to have a red tree so builds don't go to users than to have builds going to users with this fix.  :(

Comment 6

[Jorg K (CEST = GMT+2)]

Too late now, the Daily run has gone through with it. Looks like 1438512 already has an r+ patch, so please land this and I'll take it from there.

All I can offer for now is to have a release assert instead of the removed code so the program will just crash and re-run a Daily on that. But I don't think it's worth the effort.

Maybe I/you should talk to the sheriffs and get bug 1438512 landed directly on M-C, so I back this out and rerun the Daily.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d0777339c5c9
Backed out changeset bbb96e5f8fa8 for being incorrect. nsITreeBoxObject::SetView() was restored in bug 1438512. a=jorgk