1438653 - Setup WNP for users coming from <59.0 and receiving the latest 59.0 release

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Eric Renaud [:erenaud]]

+++ This bug was initially created as a clone of Bug #1428419 +++

Request is to turn on the /whatsnew page in Firefox 59.0 release (and keep it on for 59.0.x -> (all the dot releases))

The page should be made available to all locales with same localized content in /firstrun

The page shown will be the same content (I'm confirming this) as /firstrun with the single field email CTA for Firefox Accounts.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Eric, is this all in place for 59?

Comment 2

[Eric Renaud [:erenaud]]

Yes, the content is now live and ready for QA

https://www.mozilla.org/en-US/firefox/59.0/whatsnew/

Test conditions - 

Firefox user (on Firefox) not logged into Firefox Account is shown a Firefox Account Sign up CTA (all 43 locales)
Firefox user (on Firefox) logged into Firefox Account is shown a Firefox Mobile CTA (QR Code, all 43 locales)

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

avaida, fyi for testing on 59 when your team tests What's New Pages. I don't think you have to check all 43 locales though - a spot check is fine!

Comment 4

[[e-mail] (:bhearsum)]

I'll be taking care of this when we have an RC that we might actually ship. There's no point in doing this until QE is going to run release-cdntest tests.

Liz tells me that RC2 has a good chance of shipping, so I'll probably set it up for that once the builds are ready.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks Ben! Or, we could set those rules up for localtest. I think the release candidate is where localtest can come in handy, since it gives QA folks more time to test this.

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #5)
> Thanks Ben! Or, we could set those rules up for localtest. I think the
> release candidate is where localtest can come in handy, since it gives QA
> folks more time to test this.

Oh yes - localtest can have them too. That's no problem.

Comment 7

[Bogdan Maris, Desktop Test Engineering]

Hello, we prepared a testplan[1] for WNP testing Fx59, and similar with what we did before (56 and others) it would be nice to have the rules in localtest as well just for safety. 
Also is there someone we can contact in our timezone, in case we have questions?

*[1] - https://public.etherpad-mozilla.org/p/wnp-fx59

Comment 8

[Julien Cristau [:jcristau]]

:mtabara should be around this afternoon, or I can try to help out.

Comment 9

[Johan Lorenzo [:jlorenzo]]

I just created [1] to test the WNP on release-localtest.

[1] https://aus4-admin.mozilla.org/rules/783 and https://aus4-admin.mozilla.org/rules/782

Comment 10

[Bogdan Maris, Desktop Test Engineering]

(In reply to Julien Cristau [:jcristau] from comment #8)
> :mtabara should be around this afternoon, or I can try to help out.

Thanks! We finished testing WNP on release-localtest, everything worked as expected. Only one little issue on vi locale, the WNP is not localized but I guess that's something that l10n team should handle. Please let me know when this rules are pushed to release-cdntest so we can retest.

More details about our testing can be seen in the etherpad from comment 7.

Comment 11

[[e-mail] (:bhearsum)]

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #10)
> (In reply to Julien Cristau [:jcristau] from comment #8)
> > :mtabara should be around this afternoon, or I can try to help out.
> 
> Thanks! We finished testing WNP on release-localtest, everything worked as
> expected. Only one little issue on vi locale, the WNP is not localized but I
> guess that's something that l10n team should handle. Please let me know when
> this rules are pushed to release-cdntest so we can retest.
> 
> More details about our testing can be seen in the etherpad from comment 7.

If you have time, would you mind re-testing the WNP on release-localtest? It was originally set-up using an old style of configuration, and we updated it to use the new style a few minutes ago.

Comment 12

[Bogdan Maris, Desktop Test Engineering]

(In reply to Ben Hearsum (:bhearsum) from comment #11)
> (In reply to Bogdan Maris, QA [:bogdan_maris] from comment #10)
> > (In reply to Julien Cristau [:jcristau] from comment #8)
> > > :mtabara should be around this afternoon, or I can try to help out.
> > 
> > Thanks! We finished testing WNP on release-localtest, everything worked as
> > expected. Only one little issue on vi locale, the WNP is not localized but I
> > guess that's something that l10n team should handle. Please let me know when
> > this rules are pushed to release-cdntest so we can retest.
> > 
> > More details about our testing can be seen in the etherpad from comment 7.
> 
> If you have time, would you mind re-testing the WNP on release-localtest? It
> was originally set-up using an old style of configuration, and we updated it
> to use the new style a few minutes ago.

Sure thing, it's been done. We found a few issues but Ben fixed them on the spot and we verified everything is fine now for release-localtest.

Comment 13

[[e-mail] (:bhearsum)]

Eric, can you confirm which locales should get the WNP? We have 74 in our list right now, but comment #2 seems to imply that there should only be 43?

Our list is: af, ar, ast, az, be, bg, bs, ca, cak, cs, cy, da, de, dsb, el, en-GB, en-US, eo, es-AR, es-CL, es-ES, es-MX, et, eu, fa, ff, fi, fr, fy-NL, ga-IE, gu-IN, he, hi-IN, hsb, hu, hy-AM, id, is, it, ja, ja-JP-mac, ka, kab, kk, ko, lij, lt, ml, mr, ms, my, nb-NO, nl, nn-NO, pa-IN, pl, pt-BR, pt-PT, rm, ro, ru, sk, sl, sq, sr, sv-SE, ta, te, th, tr, uk, vi, zh-CN, zh-TW

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Here's the list of locales eric and flod mentioned:
an, bg, bs, cak, cs, cy, da, de, dsb, eo, en-US, es-AR, es-CL, es-ES, es-MX, fi, fr, fy-NL, gu-IN, hsb, hu, hy-AM, it, ja, ka, ms, nb-NO, nl, nn-NO, pl, pt-BR, pt-PT, ru, sk, sl, sq, sv-SE, tr, uk, zh-CN, zh-TW

Comment 15

[Eric Renaud [:erenaud]]

Ben - thanks for your patience here.

I diffed the two lists of 41 and 43 and found those to be en-US, et, fa, ja-JP-mac and confirmed that the latter 3 are indeed localized. I'm not sure if there's special treatment or not for en-US as default, but wanted be sure we kept it in to be sure.

So the list is now 44, as follows:

an, bg, bs, cak, cs, cy, da, de, dsb, en-US, eo, es-AR, es-CL, es-ES, es-MX, et, fa, fi, fr, fy-NL, gu-IN, hsb, hu, hy-AM, it, ja, ja-JP-mac, ka, ms, nb-NO, nl, nn-NO, pl, pt-BR, pt-PT, ru, sk, sl, sq, sv-SE, tr, uk, zh-CN, zh-TW

Comment 16

[[e-mail] (:bhearsum)]

(In reply to Eric Renaud from comment #15)
> Ben - thanks for your patience here.
> 
> I diffed the two lists of 41 and 43 and found those to be en-US, et, fa,
> ja-JP-mac and confirmed that the latter 3 are indeed localized. I'm not sure
> if there's special treatment or not for en-US as default, but wanted be sure
> we kept it in to be sure.
> 
> So the list is now 44, as follows:
> 
> an, bg, bs, cak, cs, cy, da, de, dsb, en-US, eo, es-AR, es-CL, es-ES, es-MX,
> et, fa, fi, fr, fy-NL, gu-IN, hsb, hu, hy-AM, it, ja, ja-JP-mac, ka, ms,
> nb-NO, nl, nn-NO, pl, pt-BR, pt-PT, ru, sk, sl, sq, sv-SE, tr, uk, zh-CN,
> zh-TW

I updated Balrog - we're all set for next week unless this list changes again.

Comment 17

[Francesco Lodolo [:flod]]

en-US should be in the list, based on previous experiences with WNP. 

Normally, I would generate it via script to avoid manual errors, it didn't happen for 59 given that I had to provide a list before the page was actually there. One more reason to avoid that mess, we would have saved a lot of confusion (to which I contributed).