Closed Bug 1438696 Opened 6 years ago Closed 6 years ago

Inspector reboots when toggling RDM

Categories

(DevTools :: Responsive Design Mode, defect, P2)

defect

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file)

STR:

1. Go to some page
2. Open toolbox to Inspector
3. Open RDM

ER:

RDM opens, Inspector should remain unchanged.

AR:

RDM opens, the Inspector reboots as if the document had been reloaded.
The root cause appears to be the tab actor gets pagehide / pageshow events during the RDM frame swap, and these emit events that reboot the Inspector.
Filed bug 1438697 to add some metadata on these events so we can distinguish them.
Comment on attachment 8951759 [details]
Bug 1438696 - Stop Inspector from rebooting on RDM toggle.

https://reviewboard.mozilla.org/r/221028/#review227390

Looks good, assuming platform accepts the addition of this chrome only flag.
Attachment #8951759 - Flags: review?(poirot.alex) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b1e9af56de01
Stop Inspector from rebooting on RDM toggle. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/b1e9af56de01
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
I have reproduced this bug with Nightly 60.0a1 (2018-02-15) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20180402175344
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
QA Whiteboard: [bugday-20180418]
Reproduced this bug on Nightly 60.0a1 (2018-02-15) (64-bit); (Build ID: 20180215103933) in Linux,64 bit

This Bug is now verified as fixed on Latest Developer Edition 60.0b14 (64-bit).

Build ID: 20180419200216
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
QA Whiteboard: [bugday-20180418] → [bugday-20180418] [testday-20180420]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.