1438696 - Inspector reboots when toggling RDM

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Go to some page
2. Open toolbox to Inspector
3. Open RDM

ER:

RDM opens, Inspector should remain unchanged.

AR:

RDM opens, the Inspector reboots as if the document had been reloaded.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The root cause appears to be the tab actor gets pagehide / pageshow events during the RDM frame swap, and these emit events that reboot the Inspector.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Filed bug 1438697 to add some metadata on these events so we can distinguish them.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1438696 - Stop Inspector from rebooting on RDM toggle.

Currently, if you open the Inspector on some page, then enter RDM, the Inspector
will "reboot" (reload all panels) because it believes the document has reloaded.

However, it's not really true in this case.  Instead, it's an artifact of the
pagehide / pageshow events that are triggered when swapping frames like RDM
does.  Bug 1438697 adds a chrome-only property that we then use here to
distinguish this case.

Review commit: https://reviewboard.mozilla.org/r/221028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221028/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=228748be9d4fb2248098a51c6c60d0586d86b567

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8951759 [details]
Bug 1438696 - Stop Inspector from rebooting on RDM toggle.

https://reviewboard.mozilla.org/r/221028/#review227390

Looks good, assuming platform accepts the addition of this chrome only flag.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1e9af56de01
Stop Inspector from rebooting on RDM toggle. r=ochameau

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b1e9af56de01

Comment 8

[Md Maruf Rahman]

I have reproduced this bug with Nightly 60.0a1 (2018-02-15) on Windows 10, 64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20180402175344
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0

Comment 9

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced this bug on Nightly 60.0a1 (2018-02-15) (64-bit); (Build ID: 20180215103933) in Linux,64 bit

This Bug is now verified as fixed on Latest Developer Edition 60.0b14 (64-bit).

Build ID: 20180419200216
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0