1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P1)

Description

[Robin Steuber (they/them) [:bytesized]]

The current implementation of the "DisableAppUpdate" enterprise policy disables the UI for changing the App update setting in about:preferences. However, the option that is left selected is "Automatically Install Updates", which is obviously wrong. The option that should be selected is "Never Check for Updates".

Comment 1

[Robin Steuber (they/them) [:bytesized]]

Attachment: Bug 1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active

Review commit: https://reviewboard.mozilla.org/r/221064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221064/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8951794 [details]
Bug 1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active

https://reviewboard.mozilla.org/r/221064/#review229636

Sorry for the slow review turn around time. I promise to be quicker on your next review.

Can you please add a test for this? I worry that with features like PolicyEngine that might not get a lot of use by Nightly users we won't notice things like this breaking until the feature is on Beta/Release.

Comment 3

[Robin Steuber (they/them) [:bytesized]]

Comment on attachment 8951794 [details]
Bug 1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/221064/diff/1-2/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8951794 [details]
Bug 1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active

https://reviewboard.mozilla.org/r/221064/#review229660

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ab890e2b9c5
Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active r=jaws

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9ab890e2b9c5

Comment 7

[Abe - QA (:Abe_LV)]

We tested this and verified as fixed.
With this fix, "Never Check for Updates" is selected and greyed out in "about:preferences" when DisableAppUpdate policy is in use.

Test case and run is available here- https://testrail.stage.mozaws.net/index.php?/tests/view/372330&group_by=cases:section_id&group_id=14918&group_order=asc