Closed Bug 1438925 Opened 6 years ago Closed 6 years ago

Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active

Categories

(Firefox :: Enterprise Policies, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 60
Tracking Status
firefox60 --- verified

People

(Reporter: bytesized, Assigned: bytesized)

References

Details

Attachments

(1 file)

The current implementation of the "DisableAppUpdate" enterprise policy disables the UI for changing the App update setting in about:preferences. However, the option that is left selected is "Automatically Install Updates", which is obviously wrong. The option that should be selected is "Never Check for Updates".
Attachment #8951794 - Flags: review?(jaws)
Blocks: 1433173
No longer blocks: policies-mvp
Comment on attachment 8951794 [details]
Bug 1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active

https://reviewboard.mozilla.org/r/221064/#review229636

Sorry for the slow review turn around time. I promise to be quicker on your next review.

Can you please add a test for this? I worry that with features like PolicyEngine that might not get a lot of use by Nightly users we won't notice things like this breaking until the feature is on Beta/Release.
Attachment #8951794 - Flags: review?(jaws) → review-
Comment on attachment 8951794 [details]
Bug 1438925 - Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active

https://reviewboard.mozilla.org/r/221064/#review229660

Thanks!
Attachment #8951794 - Flags: review?(jaws) → review+
Blocks: policies-mvp
No longer blocks: 1433173
Pushed by ksteuber@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ab890e2b9c5
Select "Never check for updates" in Preferences UI when DisableAppUpdate policy is active r=jaws
https://hg.mozilla.org/mozilla-central/rev/9ab890e2b9c5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
We tested this and verified as fixed.
With this fix, "Never Check for Updates" is selected and greyed out in "about:preferences" when DisableAppUpdate policy is in use.

Test case and run is available here- https://testrail.stage.mozaws.net/index.php?/tests/view/372330&group_by=cases:section_id&group_id=14918&group_order=asc
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: