1439406 - MOZ_CRASH(accessing non-early pref consoleservice.logcat before late prefs are set)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

I see this crash a lot when running GeckoView under e10s

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1439406 - Add consoleservice.logcat as early pref;

"consoleservice.logcat" can apparently be accessed early enough in the
content process. This is only a problem when running GeckoView under
e10s.

Review commit: https://reviewboard.mozilla.org/r/221500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221500/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8952251 [details]
Bug 1439406 - Add consoleservice.logcat as early pref;

https://reviewboard.mozilla.org/r/221500/#review227308

I think this change is fine, but this file has a giant "DO NOT ADD PREFS TO THIS LIST WITHOUT DOM PEER REVIEW" warning at the top, and I'm not a DOM peer, so I will defer to a DOM peer.

The good news is that I have a plan for getting rid of this list, in bug 1436911.

Comment 3

[Andrew McCreight [:mccr8]]

Dupe of bug 1430500?

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 8952251 [details]
Bug 1439406 - Add consoleservice.logcat as early pref;

https://reviewboard.mozilla.org/r/221500/#review227320

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66b561299185
Add consoleservice.logcat as early pref; r=mccr8

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/66b561299185