1439459 - MOZ_ANDROID_GOOGLE_PLAY_SERVICES doesn't seem to be set in absence of explicit --without-google-play-services

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[:Grisha Kruglov]

This crash happens when a push message is received (in this case, it's a "you're verified" confirmation push message from FxA). Specifically, it's triggered by a GoogleApiAvailability.isGooglePlayServicesAvailable(context) check in the GcmTokenClient.

This is on a current m-c build, without the --without-google-play-services flag anywhere, AFAIK. I'm expecting play services to be enabled in the default build configuration, but we seem to be failing to set MOZ_ANDROID_GOOGLE_PLAY_SERVICES flag and thus aren't including the 'com.google.android.gms.version' key in the AndroidManifest file.

Nick, does this seem wrong to you?

02-19 19:26:14.469  5416  5437 E AndroidRuntime: FATAL EXCEPTION: GeckoBackgroundThread
02-19 19:26:14.469  5416  5437 E AndroidRuntime: Process: org.mozilla.fennec_grisha, PID: 5416
02-19 19:26:14.469  5416  5437 E AndroidRuntime: java.lang.IllegalStateException: The meta-data tag in your app's AndroidManifest.xml does not have the right value.  Expected 8487000 but found 0.  You must have the following declaration within the <application> element:     <meta-data android:name="com.google.android.gms.version" android:value="@integer/google_play_services_version" />
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at com.google.android.gms.common.zze.zzan(Unknown Source:232)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at com.google.android.gms.common.zze.isGooglePlayServicesAvailable(Unknown Source:36)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at com.google.android.gms.common.zzc.isGooglePlayServicesAvailable(Unknown Source:0)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at com.google.android.gms.common.GoogleApiAvailability.isGooglePlayServicesAvailable(Unknown Source:0)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at org.mozilla.gecko.gcm.GcmTokenClient.ensurePlayServices(GcmTokenClient.java:52)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at org.mozilla.gecko.gcm.GcmTokenClient.getToken(GcmTokenClient.java:70)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at org.mozilla.gecko.push.PushManager.advanceRegistration(PushManager.java:247)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at org.mozilla.gecko.push.PushManager.advanceRegistration(PushManager.java:243)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at org.mozilla.gecko.push.PushManager.subscribeChannel(PushManager.java:107)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at org.mozilla.gecko.push.PushService.handleMessage(PushService.java:417)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:341)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:790)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:164)
02-19 19:26:14.469  5416  5437 E AndroidRuntime: 	at org.mozilla.gecko.util.GeckoBackgroundThread.run(GeckoBackgroundThread.java:43)

Comment 1

[Nick Alexander :nalexander [he/him]]

This is all kinds of wrong.  I'll investigate.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1439459 - Expose MOZ_ANDROID_GOOGLE_PLAY_SERVICES to AndroidManifest.xml.

This was oversight when landing Bug 1419581, coupled with dedicated
testing by Grisha.  We don't expose all CONFIG values as DEFINES by
default, and I forgot to add the relevant value to the exposure list.

Review commit: https://reviewboard.mozilla.org/r/221674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/221674/

Comment 3

[:Grisha Kruglov]

Comment on attachment 8952451 [details]
Bug 1439459 - Expose MOZ_ANDROID_GOOGLE_PLAY_SERVICES to AndroidManifest.xml.

https://reviewboard.mozilla.org/r/221674/#review227604

I haven't dove into the build code, but I think this makes sense. Thanks for a quick fix!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed39e473b31e
Expose MOZ_ANDROID_GOOGLE_PLAY_SERVICES to AndroidManifest.xml. r=Grisha

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ed39e473b31e