1439464 - Browser will crash if built without play services whenever isGooglePlayServicesAvailable check is executed

Status: RESOLVED WORKSFORME

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[:Grisha Kruglov]

Assuming that we do build without Google Play Services, we end up with a browser that will crash whenever we check if play services are available. See Bug 1439459.

Affected paths are GcmTokenClient, adjust and our casting code. See https://dxr.mozilla.org/mozilla-central/search?q=isGooglePlayServicesAvailable&=mozilla-central

The naive thing might be to simply undo the AndroidManifest change (https://hg.mozilla.org/integration/autoland/rev/c10704fa7133#l1.33).

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to :Grisha Kruglov from comment #0)
> Assuming that we do build without Google Play Services, we end up with a
> browser that will crash whenever we check if play services are available.
> See Bug 1439459.
> 
> Affected paths are GcmTokenClient, adjust and our casting code. See
> https://dxr.mozilla.org/mozilla-central/
> search?q=isGooglePlayServicesAvailable&=mozilla-central

Without GPS, we can't use GCM:

https://searchfox.org/mozilla-central/rev/0c0ddaa7e859a2b76a56a0e2e9c0de88af166812/mobile/android/moz.configure#180

nor Adjust:

https://searchfox.org/mozilla-central/rev/0c0ddaa7e859a2b76a56a0e2e9c0de88af166812/mobile/android/moz.configure#141

nor our casting code.  I don't see a hard barrier at configure time, but the default is correct

https://searchfox.org/mozilla-central/rev/0c0ddaa7e859a2b76a56a0e2e9c0de88af166812/mobile/android/moz.configure#35

and the compile will fail due to not being able to find the GPS symbols used for ChromeCast.

Closing this one out.