1439469 - Stop using INSTALL_EXTENSION_ID to build calendar.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Tom Prince [:tomprince]]

This logic is going away, and it makes the build simpler as well.

Comment 1

[Phabricator Automation]

Attachment: Bug 1439469 Package lightning directly as part of thunderbird; r?Fallen

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8bbed059de0a
Package lightning directly as part of thunderbird; r=me

Comment 3

[:aceman]

What is this actually doing?

Comment 4

[Tom Prince [:tomprince]]

This is getting rid of all the special case code to package an XPI for lightening, to then turn around and install all those files as part of thunderbird (part of that depends on makefile logic in m-c that is going away). Instead, this just installs the files directly into thunderbird where it will get picked up by the installer.

The primary reason for this is that the automation around packaging and L10n repacks in taskcluster isn't happy with the extra XPI being generated. In addition, since the code for handling lightening was unique, it created a maintenance burden as changes happened to the m-c L10n code, that needed to be ported to lightening.

Comment 5

[Jorg K (CEST = GMT+2)]

I don't think it was a good idea to do this:
https://dxr.mozilla.org/comm-central/rev/8d636ad5810b5586433294c16cb2376d826fcca8/mail/locales/Makefile.in#97

Like this, we can't switch off Calendar any more in mail/config/mozconfigs/common :-(

Comment 6

[Jorg K (CEST = GMT+2)]

Discussed on IRC, will fix it right now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/28488be2f11c
Follow-up: Don't unconditionally reference calendar locales. r=tomprince (via IRC)

Comment 8

[Phabricator Automation]

Attachment: Bug 1439469: Remove unpacked lightening extension on upgrade; r?Fallen

Comment 9

[Frank-Rainer Grahl (:frg)]

Jorg, this seems to have been uplifted to the beta TB 60 branch. Could you change the tracking flags if this hasn't been a mistake.

https://hg.mozilla.org/releases/comm-beta/rev/7cfa96f86122

Comment 10

[Jorg K (CEST = GMT+2)]

Like so?

Comment 11

[Frank-Rainer Grahl (:frg)]

Thanks. Just wanted to be sure because I need to backport additional parts of bug 1451847 now.

Comment 12

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-esr60/rev/40dfb7efc722

Comment 13

[Jan Horak [:jhorak]]

To build langpacks for the lightning package I use:
make AB_CD=en-US L10N_XPI_NAME=lightning libs-$lang
That worked in 52, with this change applied, it no longer works. How can I build the langpacks for the lightning extension for the case we're building TB for the Linux distro (ie. we provide locales to the users without need of downloading them from mozilla)?