Closed Bug 1439547 Opened 6 years ago Closed 5 years ago

SiteDataManager.jsm should have unit/xpcshell tests

Categories

(Firefox :: Settings UI, enhancement, P2)

Product:
Firefox
Component:
Settings UI
Version:
60 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Iteration:
61.1 - Mar 26
Tracking Flags:
Tracking Status
firefox60 --- affected

People

(Reporter: johannh, Assigned: johannh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [storage-v2][fixed by bug 1523272]) 

SiteDataManager.jsm is only tested in the browser_siteData.js test (siteData2 and 3 mock its functionality). That means the module is woefully under-asserted considering the fact that it's very privacy-sensitive.
I'm planning to move the SiteDataManager into browser/modules in bug 1348223, so we might want to add tests in that directory afterwards.
Priority: -- → P3
We will take this for 61.
Iteration: --- → 61.1 - Mar 26
Priority: P3 → P1
Whiteboard: [storage-v2][triage] → [storage-v2]
Priority: P1 → P2

I added tests in bug 1523272.

Assignee: nobody → jhofmann
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [storage-v2] → [storage-v2][fixed by bug 1523272]
You need to log in before you can comment on or make changes to this bug.