Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Every once in a while we delete some stuff from this file (see bug 737996, ~6 years ago) and I think it's past time for the rest to go.

The design here was to allow embedders to support multiple versions of SpiderMonkey with a single codebase... or something? Now that I'm thinking about it, this really makes no sense at all.

The remaining ifdef'd features are:

- .__proto__ and .__defineGetter__() - standardized in B.2.2, we're stuck with them for now

- uneval() and .toSource() - they are handy, let's keep them

In the unlikely event that we ever do decide to blow away one of these, the macros won't be much help.
Attachment #8952832 - Flags: review?(jdemooij)
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Blocks: 1439063
Comment on attachment 8952832 [details] [diff] [review]
Remove jsversion.h

Review of attachment 8952832 [details] [diff] [review]:
-----------------------------------------------------------------

('m not a fan of uneval/toSource being exposed to content, but I agree these #defines aren't useful.)
Attachment #8952832 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/03a00bb49a69
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.