1440043 - Remove jsversion.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jason Orendorff [:jorendorff]]

Every once in a while we delete some stuff from this file (see bug 737996, ~6 years ago) and I think it's past time for the rest to go.

The design here was to allow embedders to support multiple versions of SpiderMonkey with a single codebase... or something? Now that I'm thinking about it, this really makes no sense at all.

The remaining ifdef'd features are:

- .__proto__ and .__defineGetter__() - standardized in B.2.2, we're stuck with them for now

- uneval() and .toSource() - they are handy, let's keep them

In the unlikely event that we ever do decide to blow away one of these, the macros won't be much help.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Remove jsversion.h

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8952832 [details] [diff] [review]
Remove jsversion.h

Review of attachment 8952832 [details] [diff] [review]:
-----------------------------------------------------------------

('m not a fan of uneval/toSource being exposed to content, but I agree these #defines aren't useful.)

Comment 3

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03a00bb49a69b334c06c567a3c2bc198686f229e
Bug 1440043 - Remove jsversion.h. r=jandem.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/03a00bb49a69