1440247 - Move gIdentityHandler into its own file

Status: RESOLVED FIXED

(Firefox :: Site Identity, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

gIdentityHandler occupies over a 1000 lines of browser.js, it should really be in its own browser-identity.js file.

Comment 1

[:prathiksha]

Attachment: Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js).

Review commit: https://reviewboard.mozilla.org/r/231592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/231592/

Comment 2

[Dão Gottwald [:dao]]

"identity" is a bit overloaded. browser-siteIdentity.js maybe? Also, please use hg copy to create that new file.

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8962722 [details]
Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js).

https://reviewboard.mozilla.org/r/231592/#review237610

I concur with dao, browser-siteidentity.js seems like a better name. I also agree that it would be better to hg cp browser.js browser-siteidentity.js and then just remove the non-gIdentityHandler code (this way we preserve blame and it's easier to review).

Thanks!

::: browser/base/content/global-scripts.inc:16
(Diff revision 1)
>  Components.utils.import("resource://gre/modules/Services.jsm");
>  
>  for (let script of [
>    "chrome://browser/content/browser.js",
>  
> +  "chrome://browser/content/browser-identity.js",

Please put this in the correct alphabetic position.

::: browser/base/jar.mn:50
(Diff revision 1)
>          content/browser/aboutTabCrashed.js            (content/aboutTabCrashed.js)
>          content/browser/aboutTabCrashed.xhtml         (content/aboutTabCrashed.xhtml)
>  *       content/browser/browser.css                   (content/browser.css)
>          content/browser/browser.js                    (content/browser.js)
>  *       content/browser/browser.xul                   (content/browser.xul)
> +        content/browser/browser-identity.js           (content/browser-identity.js)

Please put this in the correct alphabetic position.

Comment 4

[Johann Hofmann [:johannh]]

err, or siteIdentity, I don't really care about the case there :)

Comment 5

[:prathiksha]

Comment on attachment 8962722 [details]
Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231592/diff/1-2/

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8962722 [details]
Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js).

https://reviewboard.mozilla.org/r/231592/#review238754

Thanks!

Comment 7

[:prathiksha]

Comment on attachment 8962722 [details]
Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231592/diff/2-3/

Comment 8

[:prathiksha]

Comment on attachment 8962722 [details]
Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/231592/diff/3-4/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a947310989
Move gIdentityHandler into its own file (browser-siteIdentity.js). r=johannh

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/01a947310989