Closed Bug 1440247 Opened 2 years ago Closed 2 years ago

Move gIdentityHandler into its own file

Categories

(Firefox :: Site Identity, enhancement, P3)

60 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: johannh, Assigned: prathiksha)

References

Details

Attachments

(1 file)

gIdentityHandler occupies over a 1000 lines of browser.js, it should really be in its own browser-identity.js file.
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
"identity" is a bit overloaded. browser-siteIdentity.js maybe? Also, please use hg copy to create that new file.
Comment on attachment 8962722 [details]
Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js).

https://reviewboard.mozilla.org/r/231592/#review237610

I concur with dao, browser-siteidentity.js seems like a better name. I also agree that it would be better to hg cp browser.js browser-siteidentity.js and then just remove the non-gIdentityHandler code (this way we preserve blame and it's easier to review).

Thanks!

::: browser/base/content/global-scripts.inc:16
(Diff revision 1)
>  Components.utils.import("resource://gre/modules/Services.jsm");
>  
>  for (let script of [
>    "chrome://browser/content/browser.js",
>  
> +  "chrome://browser/content/browser-identity.js",

Please put this in the correct alphabetic position.

::: browser/base/jar.mn:50
(Diff revision 1)
>          content/browser/aboutTabCrashed.js            (content/aboutTabCrashed.js)
>          content/browser/aboutTabCrashed.xhtml         (content/aboutTabCrashed.xhtml)
>  *       content/browser/browser.css                   (content/browser.css)
>          content/browser/browser.js                    (content/browser.js)
>  *       content/browser/browser.xul                   (content/browser.xul)
> +        content/browser/browser-identity.js           (content/browser-identity.js)

Please put this in the correct alphabetic position.
Attachment #8962722 - Flags: review?(jhofmann)
err, or siteIdentity, I don't really care about the case there :)
Comment on attachment 8962722 [details]
Bug 1440247 - Move gIdentityHandler into its own file (browser-siteIdentity.js).

https://reviewboard.mozilla.org/r/231592/#review238754

Thanks!
Attachment #8962722 - Flags: review?(jhofmann) → review+
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/01a947310989
Move gIdentityHandler into its own file (browser-siteIdentity.js). r=johannh
https://hg.mozilla.org/mozilla-central/rev/01a947310989
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Depends on: 1455243
You need to log in before you can comment on or make changes to this bug.