1440382 - [FIX] Implement changes to is="" attribute for customized built-ins

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Domenic Denicola]

See https://github.com/whatwg/dom/pull/566 (element creation and cloning changes) and https://github.com/whatwg/html/pull/3444 (HTML serialization changes)

Tests: https://github.com/w3c/web-platform-tests/pull/9505 https://github.com/w3c/web-platform-tests/pull/9508

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Some spec issues
https://github.com/whatwg/dom/issues/659
https://github.com/whatwg/html/issues/3776

I'm planning to not set is value on non-builtins ever (so is value is set only if localName isn't possibly CE name)

And when using new Foo() for builtins, is value is set to CE name.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: is_value.diff

I need to still write some tests for XML and XHTML serialization. That part is untested.
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/fe174b6bd59d5a29b374ade982a96c8f42f9beda
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe174b6bd59d5a29b374ade982a96c8f42f9beda
remote: recorded changegroup in replication log in 0.109s

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: is_value_2.diff

Some more test fixes and added tests for nsIDocumentEncoder.

The patch is a bit large, but most of it is just tests and removal of .ini-files because we now pass tests.

I added nsINode::ElementHasCustomElementData flag, because serializing innerHTML is extremely hot code, so couple of indirect accesses to get 
GetCustomElementData wouldn't be acceptable.

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/3e5b8c0642db5f732f812a30e6cad04ba59f3a08
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e5b8c0642db5f732f812a30e6cad04ba59f3a08
remote: recorded changegroup in replication log in 0.108s

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8988129 [details] [diff] [review]
is_value_2.diff

Review of attachment 8988129 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/CustomElementRegistry.h
@@ +132,5 @@
>    void Unlink();
>  
> +  nsAtom* GetIs(Element* aElement)
> +  {
> +    return aElement->NodeInfo()->NameAtom() == mType ? nullptr : mType.get();

Maybe add a comment about why we do this check. A reference to the spec, once it gets updated would be good, too.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: is_value_3.diff

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fe49c825ba3
there should be no is-attribute, only internal is-value, in custom elements, r=mrbkap

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba9f589d1c01
Backed out changeset 9fe49c825ba3 for causing bustage in builds/worker/workspace/build/src/dom/base/nsNodeUtils.cpp

Comment 8

[Eliza Balazs [:ebalazs_]]

Backed out changeset 9fe49c825ba3 (bug 1440382) for causing bustage in builds/worker/workspace/build/src/dom/base/nsNodeUtils.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9fe49c825ba3dc2e09e0c78e4efc85bd951a809b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=185338743

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185338743&repo=mozilla-inbound&lineNumber=18526

Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ba9f589d1c01d8e82e8d38c7710341deaababbfa&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: is_value_4.diff

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/08ae7c356bbe
there should be no is-attribute, only internal is-value, in custom elements, r=mrbkap

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/08ae7c356bbe