1440388 - Devtools Reps: update bundle to v0.21.0

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1440388 - devtools-reps: release v0.21.0; .

Review commit: https://reviewboard.mozilla.org/r/227380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227380/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1440388 - Fix failing test with new Reps bundle; .

Review commit: https://reviewboard.mozilla.org/r/227658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227658/

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

We don't populate the href attribute on links anymore and reps require
that we pass an openLink function to handle them.
This had an impact on the test where we are testing those links.

Review commit: https://reviewboard.mozilla.org/r/227660/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227660/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8958428 [details]
Bug 1440388 - devtools-reps: release v0.21.0; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227380/diff/1-2/

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

The bundle is not quite ready yet, but the other patches can be reviewed

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8958738 [details]
Bug 1440388 - Fix failing test with new Reps bundle; .

https://reviewboard.mozilla.org/r/227658/#review233786

Looks good to me.
R+ assuming try is green
Honza

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8958739 [details]
Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

https://reviewboard.mozilla.org/r/227660/#review233790

Thanks for working on this!

Please see my inline comment.

Honza

::: devtools/client/jsonview/test/browser_jsonview_url_linkification.js:24
(Diff revision 1)
>      let link = document.querySelector(".jsonPanelBox .treeTable .treeValueCell a");
> -    is(link.href, url, "The URL was linkified.");
> -    is(link.textContent, url, "The full URL is displayed.");
> +    is(link.textContent, expectedURL, "The full URL is displayed.");
> +    link.click();
> +  });
> +
> +  let newTab = await onTabLoaded;

What about reducing the amount of code by introducing a helper method that:

1) calls waitForNewTab
2) calls ContentTask.spawn + optionally clicks the label
3) waits for the new tab loaded

Custom message log text can be passed into the helper.

A flag indicating whether the label should be clicked can be passed in too.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1440388 - Adapt webconsole.css to the new Reps bundle; .

The .open-inspector rule is set in the reps.css CSS file, but there was also the same rule for
the old console frontend. Now that the new frontend is enabled in the webconsole, there's no way
this rule is used (you can't have the icon in the browser console).
We remove it since it clashes with the rule set in devtools-reps.
Also in this CSS file, we are overriding some colors so the objectInspector arrow matches the one
used for groups, and the rule needed to be updated.

Review commit: https://reviewboard.mozilla.org/r/228272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228272/

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8958428 [details]
Bug 1440388 - devtools-reps: release v0.21.0; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227380/diff/2-3/

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8958738 [details]
Bug 1440388 - Fix failing test with new Reps bundle; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227658/diff/1-2/

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8958739 [details]
Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227660/diff/1-2/

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8958428 [details]
Bug 1440388 - devtools-reps: release v0.21.0; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227380/diff/3-4/

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8958738 [details]
Bug 1440388 - Fix failing test with new Reps bundle; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227658/diff/2-3/

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8958739 [details]
Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227660/diff/2-3/

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8959480 [details]
Bug 1440388 - Adapt webconsole.css to the new Reps bundle; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228272/diff/1-2/

Comment 16

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8958739 [details]
Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

https://reviewboard.mozilla.org/r/227660/#review233790

> What about reducing the amount of code by introducing a helper method that:
> 
> 1) calls waitForNewTab
> 2) calls ContentTask.spawn + optionally clicks the label
> 3) waits for the new tab loaded
> 
> Custom message log text can be passed into the helper.
> 
> A flag indicating whether the label should be clicked can be passed in too.

done

Comment 17

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8959480 [details]
Bug 1440388 - Adapt webconsole.css to the new Reps bundle; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/228272/diff/2-3/

Comment 18

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8958739 [details]
Bug 1440388 - Adapt JSONViewer to the new Reps bundle; .

https://reviewboard.mozilla.org/r/227660/#review234416

Looks great now, thanks!
R+ assuming try is green
Honza

Comment 19

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8959480 [details]
Bug 1440388 - Adapt webconsole.css to the new Reps bundle; .

https://reviewboard.mozilla.org/r/228272/#review234418

Comment 20

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8958428 [details]
Bug 1440388 - devtools-reps: release v0.21.0; .

https://reviewboard.mozilla.org/r/227380/#review234420

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa46f0522cfd
devtools-reps: release v0.21.0; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/6b359e9acbf4
Fix failing test with new Reps bundle; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/03b4dbb07486
Adapt JSONViewer to the new Reps bundle; r=Honza.
https://hg.mozilla.org/integration/autoland/rev/fed69455a832
Adapt webconsole.css to the new Reps bundle; r=Honza.

Comment 22

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/aa46f0522cfd
https://hg.mozilla.org/mozilla-central/rev/6b359e9acbf4
https://hg.mozilla.org/mozilla-central/rev/03b4dbb07486
https://hg.mozilla.org/mozilla-central/rev/fed69455a832