1447820 - Middle clicking links in JSON view triggers a "pop blocked" notification instead of opening the link

Status: RESOLVED DUPLICATE of bug 1379466

(DevTools :: JSON Viewer, defect, P3)

Description

[Michael Cooper [:mythmon]]

Attachment: Screenshot from 2018-03-21 14-42-22.png

When viewing a JSON document, I middle clicked a URL to view it in a new tab. Instead of opening the tab, I got a popup blocker notification. It would be nice if this worked without special steps.

Comment 1

[Oriol Brufau [:Oriol]]

This is a regression from 1440388, which replaced href attributes with JS. I wonder why.
https://github.com/devtools-html/devtools-core/pull/989

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

This was done so the Reps consumer can decide what to do depending on what kind of url is clicked (resource: , chrome: , http: , …).
The issue described in Comment 0 need to be fixed for 61

Comment 3

[Patrick Brosset <:pbro>]

(In reply to Oriol Brufau [:Oriol] from comment #1)
> This is a regression from 1440388, which replaced href attributes with JS. I
> wonder why.
> https://github.com/devtools-html/devtools-core/pull/989
Hey Oriol, may I ask how you found the regression? I can not reproduce myself (on windows, firefox 61, middle-clicking with my mouse wheel).

Comment 4

[Oriol Brufau [:Oriol]]

(In reply to Patrick Brosset <:pbro> from comment #3)
> Hey Oriol, may I ask how you found the regression?

I had seen that bug used JS-based links so I already knew before bisecting.

Anyways I can reproduce on windows, firefox 61. I use https://api.github.com/ to test. Make sure popups are blocked in about:preferences#privacy

Comment 5

[Oriol Brufau [:Oriol]]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)
> This was done so the Reps consumer can decide what to do depending on what
> kind of url is clicked

But removing href is semantically bad. If then you want to handle it via JS, you can always use event.preventDefault().
This also breaks my workflow, now I can't right-click and choose "Save Link As". This is useful when the JSON links images, videos, etc.

Comment 6

[Marion Daly [:mdaly]]

@honza: Triage?

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can reproduce the problem. Thanks for the report!

STR:

1) Make sure to block popup windows ("Block pop-up windows" checkbox needs to be checked in about:preferences#privacy)
2) Load https://api.github.com/
3) Middle click on any link
4) A yellow notification saying that the browser prevented this site from opening a pop-up window ->  BUG

Honza

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Nicolas, any tips how we could fix this?

Honza

Comment 9

[Oriol Brufau [:Oriol]]

Just do this:

1. Add back href attributes in https://github.com/devtools-html/devtools-core/issues/1020
2. Stop using event.preventDefault() in the reps side
3. Pass the event object to openLink methods
3. Change JSON Viewer's openLink to

        openLink(str, event) {
          let u;
          try {
            u = new URL(str);
          } catch (ex) { /* the link might be bust */ }
          if (!u || !["https:", "http:"].includes(u.protocol) {
            event.preventDefault();
          }
        },

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

No activity, moving to the backlog (P3)
Honza

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Oriol, can we close this since Bug 1540069 landed?

Comment 12

[Oriol Brufau [:Oriol]]

In fact this was fixed by bug 1379466, but bug 1540069 should have done the trick too.
This can be closed unless you think a test is needed, though https://hg.mozilla.org/integration/autoland/rev/32d8c9a17e50 probably suffices.