Closed
Bug 1440435
Opened 6 years ago
Closed 6 years ago
Remove Java JAR building support from makefiles
Categories
(Firefox Build System :: Android Studio and Gradle Integration, enhancement)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
Right now, we support producing Java JAR files in moz.build and Makefile.in. It's used for Robocop (see Bug 1440433) and for the annotationProcessor JAR. Once we move annotation processing to Gradle (in some way -- see Bug 1067217 and Bug 1064554) we can get rid of this functionality entirely. That should let us remove https://searchfox.org/mozilla-central/source/config/makefiles/java-build.mk entirely \o/
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
Does this need to depend on one of Bug 1067217 or Bug 1064554, then?
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2) > Does this need to depend on one of Bug 1067217 or Bug 1064554, then? Not really -- I did the guts of the work in https://bugzilla.mozilla.org/show_bug.cgi?id=1444546 and friends; this is using an existing ticket to mop up a loose end.
|
|
||
Updated•6 years ago
|
Attachment #8980370 -
Flags: review?(core-build-config-reviews) → review?(ted)
|
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8980370 [details] Bug 1440435 - Remove final remnant of Java JAR building from Makefiles. https://reviewboard.mozilla.org/r/246546/#review252722
Attachment #8980370 -
Flags: review?(ted) → review+
Pushed by nalexander@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30fea451e27c Remove final remnant of Java JAR building from Makefiles. r=ted
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/30fea451e27c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
|
||
Updated•6 years ago
|
Assignee: nobody → nalexander
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 62 → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•