1440461 - [CSD] disable titlebar rendering for Beta/Release 59

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Martin Stránský [:stransky] (ni? me)]

[Tracking Requested - why for this release]:

The titlebar rendering is recently enabled at Beta but with many bugs fixed at Nightly. Let's disable this feature for Beta / Release 59 and ship at 60 where majority of the issues are fixed.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

The titlebar rendering on Linux/Gtk+ is recently enabled at Beta59 but with many bugs fixed at Nightly.
Let's disable this feature for Beta / Release 59 and ship it at Firefox 60 where majority of the issues are fixed.

Review commit: https://reviewboard.mozilla.org/r/222504/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/222504/

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Mike, can you please check this path? Otherwise we'll ship unfinished feature at Firefox 59. Thanks!

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

https://reviewboard.mozilla.org/r/222504/#review229426

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1283299
[User impact if declined]: Users can enable unfinished feature implementation which contains visual bugs (wrong button positions on Ubuntu, wrong titlebar size and so on). That may lead to poor user experience and newly filed bugs (which are already fixed at Nightly).
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: Make sure titlebar rendering is disabled. "Tilebar" checkbox is missing at Hamburger menu -> Customise.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no.
[Why is the change risky/not risky?]:  It only reverts titlebar build config (Bug 1415481) for Beta/Release and disables WM detection.
[String changes made/needed]: none

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

Sounds sensible to ship this in 60 instead. 
This should land for 59 beta 14.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d1f52cabe41
Disable titlebar rendering for Linux/Firefox 59, r=glandium

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on nsWindow.cpp

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=165095188&repo=autoland&lineNumber=18856

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dca35aa6d1ab
Backed out changeset 9d1f52cabe41 for build bustages on nsWindow.cpp

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/222504/diff/1-2/

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Sorry, lint does not like the unused code. Added new patch and landed at try.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

Requested release land as we miss beta merge here. Try looks good.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1283299
[User impact if declined]: Users can enable unfinished feature implementation which contains visual bugs (wrong button positions on Ubuntu, wrong titlebar size and so on). That may lead to poor user experience and newly filed bugs (which are already fixed at Nightly).
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: Make sure titlebar rendering is disabled. "Tilebar" checkbox is missing at Hamburger menu -> Customise.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no.
[Why is the change risky/not risky?]:  It only reverts titlebar build config (Bug 1415481) for Beta/Release and disables WM detection.
[String changes made/needed]: none

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

OK for uplift to m-r for the 59 RC build.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/68edd6cf79ce (FIREFOX_59b_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-release/rev/95ba1f679492

Comment 14

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified that Firefox 59.0 RC build for Ubuntu no longer has the Title Bar checkbox in Customize mode using Ubuntu 14.04 x86 and 16.04 x64.

Firefox 59.0 builds were not affected by this change under Windows 10 and Mac OS X 10.13.