[CSD] disable titlebar rendering for Beta/Release 59

VERIFIED FIXED in Firefox 59

Status

()

defect
P1
normal
VERIFIED FIXED
Last year
Last year

People

(Reporter: stransky, Assigned: stransky)

Tracking

(Blocks 1 bug)

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 verified, firefox60 unaffected)

Details

Attachments

(1 attachment)

[Tracking Requested - why for this release]:

The titlebar rendering is recently enabled at Beta but with many bugs fixed at Nightly. Let's disable this feature for Beta / Release 59 and ship at 60 where majority of the issues are fixed.
Summary: [CSD] disable titlebar rendering for Beta/Release → [CSD] disable titlebar rendering for Beta/Release 59
Mike, can you please check this path? Otherwise we'll ship unfinished feature at Firefox 59. Thanks!
Flags: needinfo?(mh+mozilla)
Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

https://reviewboard.mozilla.org/r/222504/#review229426
Attachment #8953214 - Flags: review?(mh+mozilla) → review+
Flags: needinfo?(mh+mozilla)
Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1283299
[User impact if declined]: Users can enable unfinished feature implementation which contains visual bugs (wrong button positions on Ubuntu, wrong titlebar size and so on). That may lead to poor user experience and newly filed bugs (which are already fixed at Nightly).
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: Make sure titlebar rendering is disabled. "Tilebar" checkbox is missing at Hamburger menu -> Customise.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no.
[Why is the change risky/not risky?]:  It only reverts titlebar build config (Bug 1415481) for Beta/Release and disables WM detection.
[String changes made/needed]: none
Attachment #8953214 - Flags: approval-mozilla-beta?
Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

Sounds sensible to ship this in 60 instead. 
This should land for 59 beta 14.
Attachment #8953214 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9d1f52cabe41
Disable titlebar rendering for Linux/Firefox 59, r=glandium
Backed out for build bustages on nsWindow.cpp

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=165095188&repo=autoland&lineNumber=18856
Flags: needinfo?(stransky)
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dca35aa6d1ab
Backed out changeset 9d1f52cabe41 for build bustages on nsWindow.cpp
Sorry, lint does not like the unused code. Added new patch and landed at try.
Flags: needinfo?(stransky)
Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

Requested release land as we miss beta merge here. Try looks good.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1283299
[User impact if declined]: Users can enable unfinished feature implementation which contains visual bugs (wrong button positions on Ubuntu, wrong titlebar size and so on). That may lead to poor user experience and newly filed bugs (which are already fixed at Nightly).
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: Make sure titlebar rendering is disabled. "Tilebar" checkbox is missing at Hamburger menu -> Customise.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no.
[Why is the change risky/not risky?]:  It only reverts titlebar build config (Bug 1415481) for Beta/Release and disables WM detection.
[String changes made/needed]: none
Attachment #8953214 - Flags: approval-mozilla-release?
Comment on attachment 8953214 [details]
Bug 1440461 - Disable titlebar rendering for Linux/Firefox 59,

OK for uplift to m-r for the 59 RC build.
Attachment #8953214 - Flags: approval-mozilla-release? → approval-mozilla-release+
https://hg.mozilla.org/releases/mozilla-beta/rev/68edd6cf79ce (FIREFOX_59b_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-release/rev/95ba1f679492
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Verified that Firefox 59.0 RC build for Ubuntu no longer has the Title Bar checkbox in Customize mode using Ubuntu 14.04 x86 and 16.04 x64.

Firefox 59.0 builds were not affected by this change under Windows 10 and Mac OS X 10.13.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.