1440550 - Update Debugger Frontend v19

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Comment 1

[Jason Laster [:jlast]]

Attachment: rel-19.patch

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=954cfa1cdd011fcee211e4e438a1422f5edeadd8
https://github.com/devtools-html/debugger.html/compare/release-18...release-19

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8953673 [details] [diff] [review]
rel-19.patch

Review of attachment 8953673 [details] [diff] [review]:
-----------------------------------------------------------------

- Meta:
 - assigned, P3, enhancement, blocks meta: Done.
 - commit message: OK
 - less than 20 commits: OK 
- TRY
 - try run green: KO, test timing out needs fixing
 - try run has rebuild: OK
- Manual test: OK
- README: OK
- Properties file review: N/A
- New files: OK

R+ with the test timeout extended.

(related to that there's a r? for you here: https://bugzilla.mozilla.org/show_bug.cgi?id=1440102)

::: devtools/client/debugger/new/test/mochitest/browser_dbg-babel-stepping.js
@@ +78,5 @@
> +  }
> +}
> +
> +add_task(async function() {
> +  requestLongerTimeout(2);

This test is timing out too frequently. Please either disable or up this to requestLongerTimeout(3).

Also please move this to the top of the test file, by convention that's where we normally set such timeouts.

Comment 4

[Julian Descottes [:jdescottes]]

talos comparison in progress
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=1c9c1d3f8c6463a0e0db7752038317e2d3423755&newProject=try&newRevision=d21d2fda5eb7d244ca724b999aa23787c2b5951f&framework=1

Comment 5

[Julian Descottes [:jdescottes]]

Talos indicates performance regressions:

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=1c9c1d3f8c6463a0e0db7752038317e2d3423755&newProject=try&newRevision=d21d2fda5eb7d244ca724b999aa23787c2b5951f&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyImportant=1&framework=1

- complicated.jsdebugger.reload.DAMP : 5.79%
- custom.jsdebugger.open.DAMP : 26.85%
- custom.jsdebugger.reload.DAMP : 4.17%

Comment 6

[Jason Laster [:jlast]]

Attachment: rel-19-2.patch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a2ad927dcc
Update Debugger Frontend v19. r=jdescottes

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b4a2ad927dcc