Closed Bug 1440740 Opened 4 years ago Closed 4 years ago

"Warning: Calling PropTypes validators directly is not supported" when first opening Memory Tool

Categories

(DevTools :: Memory, defect, P2)

defect

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: miker, Assigned: miker)

Details

Attachments

(1 file)

STR:

1. Ensure .mozconfig contains `ac_add_options --enable-debug-js-modules`.
2. Build and run Firefox.
3. Open the DevTools Panel.
4. Select the Memory tab.
5. open the Browser Console.

This warning appears the first time the memory panel is selected:

"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types
    in MemoryApp (created by Connect(MemoryApp))
    in Connect(MemoryApp) (created by bound createElementWithValidation)
    in bound createElementWithValidation
    in Provider"

This appears to be an issue with `devtools/client/memory/app.js`

I suspect this has something to do with `childContextTypes()` and `getChildContext()`... not sure how it should be handled though.
Has Regression Range: --- → irrelevant
Has STR: --- → yes
Summary: Calling PropTypes validators directly is not supported when first opening tool → Calling PropTypes validators directly is not supported when first opening Memory Tool
This could be a conflict with our current version of Redux.
I have logged bug 1441147 for the redux upgrade.
The redux upgrade made no difference
Summary: Calling PropTypes validators directly is not supported when first opening Memory Tool → "Warning: Calling PropTypes validators directly is not supported" when first opening Memory Tool
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Comment on attachment 8954064 [details]
Bug 1440740 - Calling PropTypes validators directly is not supported when first opening Memory Tool

https://reviewboard.mozilla.org/r/223210/#review229476

Looks good
Attachment #8954064 - Flags: review?(nchevobbe) → review+
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/808d909f106b
Calling PropTypes validators directly is not supported when first opening Memory Tool r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/808d909f106b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.