1440740 - "Warning: Calling PropTypes validators directly is not supported" when first opening Memory Tool

Status: RESOLVED FIXED

(DevTools :: Memory, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

STR:

1. Ensure .mozconfig contains `ac_add_options --enable-debug-js-modules`.
2. Build and run Firefox.
3. Open the DevTools Panel.
4. Select the Memory tab.
5. open the Browser Console.

This warning appears the first time the memory panel is selected:

"Warning: Failed prop type: Calling PropTypes validators directly is not supported by the `prop-types` package. Use `PropTypes.checkPropTypes()` to call them. Read more at http://fb.me/use-check-prop-types
    in MemoryApp (created by Connect(MemoryApp))
    in Connect(MemoryApp) (created by bound createElementWithValidation)
    in bound createElementWithValidation
    in Provider"

This appears to be an issue with `devtools/client/memory/app.js`

I suspect this has something to do with `childContextTypes()` and `getChildContext()`... not sure how it should be handled though.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This could be a conflict with our current version of Redux.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I have logged bug 1441147 for the redux upgrade.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

The redux upgrade made no difference

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1440740 - Calling PropTypes validators directly is not supported when first opening Memory Tool

This one was very hard to find... we don't actually need to check for view because we would have lots of errors telling us it was missing if it was.

Review commit: https://reviewboard.mozilla.org/r/223210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223210/

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8954064 [details]
Bug 1440740 - Calling PropTypes validators directly is not supported when first opening Memory Tool

https://reviewboard.mozilla.org/r/223210/#review229476

Looks good

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8954064 [details]
Bug 1440740 - Calling PropTypes validators directly is not supported when first opening Memory Tool

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223210/diff/1-2/

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8954064 [details]
Bug 1440740 - Calling PropTypes validators directly is not supported when first opening Memory Tool

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223210/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/808d909f106b
Calling PropTypes validators directly is not supported when first opening Memory Tool r=nchevobbe

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/808d909f106b