1441029 - [FIX] Assertion failure: type != name, at dom/base/Element.cpp:4440

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Bob Clary [:bc] (inactive)]

Attachment: Log

1. https://search.aviasales.ru/MOW2203OVB1

2. Assertion failure: type != name, at /builds/worker/workspace/build/src/dom/base/Element.cpp:4440
#01: nsContentUtils::NewXULOrHTMLElement(mozilla::dom::Element**, mozilla::dom::NodeInfo*, mozilla::dom::FromParser, nsAtom*, mozilla::dom::CustomElementDefinition*) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#02: NS_NewHTMLElement(mozilla::dom::Element**, already_AddRefed<mozilla::dom::NodeInfo>&&, mozilla::dom::FromParser, nsAtom*, mozilla::dom::CustomElementDefinition*) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#03: nsHtml5TreeOperation::CreateHTMLElement(nsAtom*, nsHtml5HtmlAttributes*, mozilla::dom::FromParser, nsNodeInfoManager*, nsHtml5DocumentBuilder*, nsGenericHTMLElement* (*)(already_AddRefed<mozilla::dom::NodeInfo>&&, mozilla::dom::FromParser)) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#04: nsHtml5TreeOperation::Perform(nsHtml5TreeOpExecutor*, nsIContent**, bool*, bool*) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#05: nsHtml5TreeOpExecutor::RunFlushLoop() (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)

Nightly/60 Linux. Originally seen in Nightly/59 but not reproducible on Beta/59.

Comment 1

[Anne (:annevk)]

Bobby, seems this is your code.

Comment 2

[Bobby Holley (:bholley)]

(In reply to Anne (:annevk) from comment #1)
> Bobby, seems this is your code.

Hm, what makes you say that? This assertion is in Element::SetCustomElementData, yeah? I've never touched anything CE-related.

Comment 3

[Anne (:annevk)]

My bad, went by line number. :/

This was introduced in bug 1419662.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

data:text/html,<div is=div>

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: custom_assert_type.diff

No need to try to use invalid is attribute, since there wouldn't be a custom element for such name in the registry anyhow.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e95948e4ac6b
give up early on invalid 'is attribute values, r=mrbkap

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e95948e4ac6b