Closed
Bug 1441063
Opened 7 years ago
Closed 7 years ago
Misleading bugzilla comment when asking for re-review
Categories
(Conduit :: Phabricator, defect)
Conduit
Phabricator
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mt, Assigned: zalun)
References
()
Details
(Keywords: conduit-backlog, conduit-triaged)
Attachments
(1 obsolete file)
STR:
1. Ask for review
2. Get r+ conditional on "small" tweaks
3. Discover problem that requires a non-trivial fix
4. Post larger fix and "Request Review" using the phab UI
Expected:
Remove r+
A message saying as much
Actual:
Remove r+ (good)
A very misleading message: <reviewer name> has been removed from the revision.
Example: https://bugzilla.mozilla.org/show_bug.cgi?id=1309068#c7
|
||
Comment 1•7 years ago
|
||
Can we have something clearer for this type of situation, do you think?
Flags: needinfo?(dkl)
|
||
Comment 2•7 years ago
|
||
(In reply to Mark Côté [:mcote] from comment #1)
> Can we have something clearer for this type of situation, do you think?
Yeah I will take a look at it. It is a matter of what we can get from the Phabricator API as to what thing happened and put the proper comment in BMO for that.
dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Flags: needinfo?(dkl)
|
|
||
Updated•7 years ago
|
|
|
Assignee | |
Updated•7 years ago
|
Assignee: dkl → pzalewa
|
||
Comment 3•7 years ago
|
||
|
|
||
Updated•7 years ago
|
Attachment #8962710 -
Attachment is obsolete: true
|
||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Keywords: conduit-backlog
Whiteboard: [phabricator-backlog]
You need to log in
before you can comment on or make changes to this bug.
Description
•