1441278 - Missing line numbers in failing unit tests

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Andrei Oprea [:andreio]]

Attachment: after.png

See attachments.

Comment 1

[Andrei Oprea [:andreio]]

Attachment: before.png

Notice the difference in the last line between the two screenshots.
Rolling back pre-source-maps fixes it.

Comment 2

[Kate Hudson :k88hudson]

After some investigation, I believe this is actually due to the upgrade to Karma 2.0 rather than the introduction of source maps with webpack.

Installing karma 1.7.0 fixes the issue for me.

Related issue here: https://github.com/karma-runner/karma/issues/2930

We could consider downgrading, or perhaps just wait for a fix to karma? Looks like someone was making some progress on it in the last couple of weeks

Comment 3

[Tim Spurway [:tspurway]]

Let's downgrade karma to 1.7.1

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4020

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/d8e8a193141a04d867776fc1057282e35fe0f037
Fix Bug 1441278 - Missing line numbers in failing unit tests.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4032

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/cff509da2bcb46b9331a31aa3e47ad9df51d8f7e
Fix Bug 1441278 - Update package-lock.json

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9e902a91c375

Comment 9

[Ed Lee :Mardak]

Looks like this got fixed in karma 2.0.2:

01 05 2018 13:53:45.382:INFO [karma]: Karma v2.0.2 server started at http://0.0.0.0:9876/
      expected { Object (id, icon, ...) } to have property 'id' of 'menuaction_pin', but got 'menu_action_pin'
      AssertionError@node_modules/chai/chai.js:9320:13
      [3]</module.exports/Assertion.prototype.assert@node_modules/chai/chai.js:239:13

Compared to 2.0.0:
01 05 2018 13:50:37.619:INFO [karma]: Karma v2.0.0 server started at http://0.0.0.0:9876/
      expected { Object (id, icon, ...) } to have property 'id' of 'menuaction_pin', but got 'menu_action_pin'
      AssertionError@base/node_modules/chai/chai.js?40e7aa72e9665366bfd82579520de4fb0754dfae:9320:13
      [3]</module.exports/Assertion.prototype.assert@base/node_modules/chai/chai.js?40e7aa72e9665366bfd82579520de4fb0754dfae:239:13

I'll update karma in bug 1436228.