1436228 - Green up our JS dependencies for Firefox 61

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ed Lee :Mardak]

Let's try to keep our dependencies up to date each cycle. Steps:

1) green up dependencies that are already passing tests
- next-update --test './node_modules/.bin/npm-run-all test buildmc' --type dev
- for non-dev dependencies, probably include --test 'npm run mochitest'
- maybe --without istanbul-instrumenter-loader,karma-sinon,loader-utils (as they failed previously)

2) fix up dependencies that require changes as separate commits
- non-dev dependencies probably require vendor/ file changes

3) create PR with greening up commits
- good to link to major version changes release tags
-- e.g., https://github.com/mochajs/mocha/releases/tag/v5.0.0

4) file new bug for next cycle

Comment 1

[Ed Lee :Mardak]

Extra care in not regressing https://github.com/mozilla/activity-stream/pull/4020 if updating karma

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Might be worth trying out https://renovateapp.com/ for this.  At first glance, it appears to have a bunch of the configurability that we always wished greenkeeper had.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

I've got a couple of PRs from it in my fork of activity stream: https://github.com/dmose/activity-stream/pulls

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4135

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/8ed3d178495433768eb4a7bbc90d4f9dd5ae1bc6
Merge pull request #4135 from Mardak/b1436228-green

Fix Bug 1436228 - Green up our JS dependencies for Firefox 61

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a9f5a8dc2e22