[FIX]API Freeze - Need to create PrintSettings w/o nsIWebBrowserPrint

VERIFIED FIXED in mozilla1.0

Status

()

Core
Printing: Output
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: rods (gone), Assigned: rods (gone))

Tracking

({topembed+})

Trunk
mozilla1.0
x86
Windows 2000
topembed+
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt2])

Attachments

(3 attachments)

(Assignee)

Description

16 years ago
There needs to be a service for creating the nsIPrintSettings objects and then
remove them from nsIWebBrowserPrint.

Because there times when you will need to get a PrintSettings object and you do
not have a nsIWebBrowserPrint object.

The new service "nsIPrintSettingsService" will be implemented by nsPrintOptions
and I have already filed a bug 144114 for switch over the impl's name.

For now, nsIPrintOptions and nsIPrintSettingsService will have the same CID
because the same object implements both services. NOTE: only internal classes
will ever need to create a nsIPrintOptions object.
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: topembed
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 1

16 years ago
Created attachment 83351 [details] [diff] [review]
patch

Problem: You cannot create a PrintSettings object without a nsIWebBrowserPrint
iface which requires a loaded document. 

Solution: Move the creation and manipulation of PSs to their own service.

This patch does the following:
1) Introduces a new public interface nsIPrintSettingService which emables
consumers to create PS objects whithout a nsIWebBrowserPrint interface
2) The implementation is nsPrintOptionsImpl which now impls the private
interface nsIPrintOptions and the public iface nsIPrintSettingsService
3) Several methods/attrs have been moved from nsIWebBrowserPrint iface to
nsIPrintSettingsService
4) The CIDs for nsIPrintOptions and nsIPrinSettingsService are now the same.
5) There is no longer a CID "@mozilla.org/gfx/printoptions;1" 
6) nsIWebBrowserPrint still has the "globalPrintSettings" attr so if you
already have an nsIWebBrowserPrint you don't have to create the PS Service to
get it.
7) A bug has been filed to rename the imlp of nsPrintOptionsImpl to
nsPrintSettingsService.
(Assignee)

Updated

16 years ago
Summary: API Freeze - Need to create PrintSettings w/o nsIWebBrowserPrint → [FIX]API Freeze - Need to create PrintSettings w/o nsIWebBrowserPrint

Comment 2

16 years ago
Comment on attachment 83351 [details] [diff] [review]
patch

sr=attinasi, assuming you document the transitional nature as we discussed on
the phone.
Attachment #83351 - Flags: superreview+
topembed+
Keywords: topembed → topembed+
(Assignee)

Comment 4

16 years ago
Created attachment 83513 [details] [diff] [review]
missed this mac build file
(Assignee)

Comment 5

16 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Keywords: adt1.0.0
Resolution: --- → FIXED
Whiteboard: [adt2]

Comment 6

16 years ago
Comment on attachment 83351 [details] [diff] [review]
patch

r=dcone
Attachment #83351 - Flags: review+
(Assignee)

Updated

16 years ago
Blocks: 99619

Comment 7

16 years ago
printing and page setup work in 5/15 build.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 8

16 years ago
Reopening, I messed a directory when making the patch and checking in
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

16 years ago
Created attachment 83920 [details] [diff] [review]
mailnews part of patch

I missed this dir for patch and checkin
(Assignee)

Updated

16 years ago
Status: REOPENED → ASSIGNED

Comment 10

16 years ago
Comment on attachment 83920 [details] [diff] [review]
mailnews part of patch

r=dcone
Attachment #83920 - Flags: review+

Comment 11

16 years ago
Comment on attachment 83920 [details] [diff] [review]
mailnews part of patch

sr=kin@netscape.com
Attachment #83920 - Flags: superreview+
(Assignee)

Comment 12

16 years ago
ducarroz says dcone's r= is fine - fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED

Comment 13

16 years ago
Rod, can you verify this and mark verified-fixed? thanks.

Comment 14

16 years ago
adding adt1.0.0+.  Please get drivers approval and then check into the 1.0 branch.
Keywords: adt1.0.0 → adt1.0.0+

Comment 15

16 years ago
marking verified...
Status: RESOLVED → VERIFIED

Comment 16

16 years ago
changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.
Keywords: adt1.0.0+ → adt1.0.1+

Comment 17

16 years ago
please land on the 1.0.1 branch. once there, remove the "mozilla1.0.1+" keyword,
and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1+
(Assignee)

Comment 18

16 years ago
checked in on branch
Keywords: mozilla1.0.1+ → fixed1.0.1

Updated

16 years ago
Keywords: fixed1.0.1 → verified1.0.1
You need to log in before you can comment on or make changes to this bug.