Closed Bug 144128 Opened 23 years ago Closed 23 years ago

[FIX]API Freeze - Need to create PrintSettings w/o nsIWebBrowserPrint

Categories

(Core :: Printing: Output, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.0

People

(Reporter: rods, Assigned: rods)

References

Details

(Keywords: topembed+, Whiteboard: [adt2])

Attachments

(3 files)

There needs to be a service for creating the nsIPrintSettings objects and then remove them from nsIWebBrowserPrint. Because there times when you will need to get a PrintSettings object and you do not have a nsIWebBrowserPrint object. The new service "nsIPrintSettingsService" will be implemented by nsPrintOptions and I have already filed a bug 144114 for switch over the impl's name. For now, nsIPrintOptions and nsIPrintSettingsService will have the same CID because the same object implements both services. NOTE: only internal classes will ever need to create a nsIPrintOptions object.
Status: NEW → ASSIGNED
Keywords: topembed
Target Milestone: --- → mozilla1.0
Attached patch patchSplinter Review
Problem: You cannot create a PrintSettings object without a nsIWebBrowserPrint iface which requires a loaded document. Solution: Move the creation and manipulation of PSs to their own service. This patch does the following: 1) Introduces a new public interface nsIPrintSettingService which emables consumers to create PS objects whithout a nsIWebBrowserPrint interface 2) The implementation is nsPrintOptionsImpl which now impls the private interface nsIPrintOptions and the public iface nsIPrintSettingsService 3) Several methods/attrs have been moved from nsIWebBrowserPrint iface to nsIPrintSettingsService 4) The CIDs for nsIPrintOptions and nsIPrinSettingsService are now the same. 5) There is no longer a CID "@mozilla.org/gfx/printoptions;1" 6) nsIWebBrowserPrint still has the "globalPrintSettings" attr so if you already have an nsIWebBrowserPrint you don't have to create the PS Service to get it. 7) A bug has been filed to rename the imlp of nsPrintOptionsImpl to nsPrintSettingsService.
Summary: API Freeze - Need to create PrintSettings w/o nsIWebBrowserPrint → [FIX]API Freeze - Need to create PrintSettings w/o nsIWebBrowserPrint
Comment on attachment 83351 [details] [diff] [review] patch sr=attinasi, assuming you document the transitional nature as we discussed on the phone.
Attachment #83351 - Flags: superreview+
topembed+
Keywords: topembedtopembed+
fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: adt1.0.0
Resolution: --- → FIXED
Whiteboard: [adt2]
Comment on attachment 83351 [details] [diff] [review] patch r=dcone
Attachment #83351 - Flags: review+
Blocks: 99619
printing and page setup work in 5/15 build.
Status: RESOLVED → VERIFIED
Reopening, I messed a directory when making the patch and checking in
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
I missed this dir for patch and checkin
Status: REOPENED → ASSIGNED
Comment on attachment 83920 [details] [diff] [review] mailnews part of patch r=dcone
Attachment #83920 - Flags: review+
Attachment #83920 - Flags: superreview+
ducarroz says dcone's r= is fine - fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago23 years ago
Resolution: --- → FIXED
Rod, can you verify this and mark verified-fixed? thanks.
adding adt1.0.0+. Please get drivers approval and then check into the 1.0 branch.
Keywords: adt1.0.0adt1.0.0+
marking verified...
Status: RESOLVED → VERIFIED
changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1 milestone. Please get drivers approval before checking in.
Keywords: adt1.0.0+adt1.0.1+
please land on the 1.0.1 branch. once there, remove the "mozilla1.0.1+" keyword, and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1+
checked in on branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: