Closed
Bug 99619
Opened 23 years ago
Closed 22 years ago
[PATCH]Freeze nsIWebBrowserPrint
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: chak, Assigned: rods)
References
()
Details
(Keywords: topembed+, Whiteboard: [adt3 RTM] [ETA 07/12])
Attachments
(2 files, 1 obsolete file)
|
638 bytes,
patch
|
kmcclusk
:
review+
sspitzer
:
superreview+
chofmann
:
approval+
|
Details | Diff | Splinter Review |
|
1.17 KB,
patch
|
kmcclusk
:
review+
waterson
:
superreview+
|
Details | Diff | Splinter Review |
Freeze nsIWebBrowserPrint* interfaces
Please refer to
http://www.mozilla.org/projects/embedding/EmbedInterfaceFreeze.html for the
issues to be addressed, if any, for this interface.
Please follow the guidelines outlined in "How to mark an interface as frozen?"
section of the document above.
|
||
Updated•23 years ago
|
QA Contact: mdunn → depstein
|
||
Updated•23 years ago
|
Target Milestone: --- → mozilla0.9.7
|
Assignee | |
Comment 2•23 years ago
|
||
This interface will soon change to include nsIPrintSettings instead of
nsIPrintOptions
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•23 years ago
|
Target Milestone: mozilla0.9.7 → mozilla0.9.9
|
|
Assignee | |
Updated•23 years ago
|
Target Milestone: mozilla0.9.9 → mozilla1.0
|
||
Comment 4•23 years ago
|
||
"embed"'s dying off. topembed is the replacemnet
|
|
||
Comment 5•23 years ago
|
||
Moving to Moz1.0, Marking nsbeta1+, topembed+
|
|
||
Comment 6•23 years ago
|
||
Setting to nsbeta1-, but leaving topembed+ since this is really only needed for
embedding.
um. before you go around freezing things, please add @throws lines so that
people can find out what are likely events.
|
|
Assignee | |
Comment 8•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
Summary: Freeze nsIWebBrowserPrint → [PATCH]Freeze nsIWebBrowserPrint
|
|
Assignee | |
Updated•23 years ago
|
Target Milestone: mozilla1.0 → mozilla1.0.1
|
|
Assignee | |
Comment 9•22 years ago
|
||
Attachment #82909 -
Attachment is obsolete: true
|
|
||
Comment 10•22 years ago
|
||
Comment on attachment 89636 [details] [diff] [review]
patch to freeze interface
r=kmcclusk@netscape.com
Attachment #89636 -
Flags: review+
|
||
Comment 11•22 years ago
|
||
Comment on attachment 89636 [details] [diff] [review]
patch to freeze interface
sr=sspitzer
Attachment #89636 -
Flags: superreview+
|
|
Assignee | |
Comment 12•22 years ago
|
||
changed status to "frozen" - fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•22 years ago
|
Keywords: adt1.0.1,
mozilla1.0.1
|
|
||
Comment 13•22 years ago
|
||
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
|
||
Comment 14•22 years ago
|
||
Adding adt1.0.1+ on behalf of the adt for checkin to the 1.0 branch. When you
check this into the branch, please change the mozilla1.0.1+ keyword to fixed1.0.1
|
||
Comment 16•22 years ago
|
||
nsIWebBrowserPrint iface is marked frozen. The only thing I noticed is that
'nsIWebProgressListener' is used for parameter input, instead of the actual
'aWPListener' variable in the comments description for print() and
printPreview(). Can we get that changed? Thanks.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 17•22 years ago
|
||
Minor change to the comments for frozen interface
|
|
Assignee | |
Updated•22 years ago
|
Status: REOPENED → ASSIGNED
|
|
Assignee | |
Updated•22 years ago
|
|
|
||
Comment 18•22 years ago
|
||
Attachment #90891 -
Flags: review+
|
||
Comment 19•22 years ago
|
||
Comment on attachment 90891 [details] [diff] [review]
patch
sr=waterson
Attachment #90891 -
Flags: superreview+
|
|
||
Comment 20•22 years ago
|
||
Removing adt1.0.1 per adt because the patch hasn't landed on the trunk and also
has not been verified
Keywords: adt1.0.1
|
|
Assignee | |
Comment 21•22 years ago
|
||
comments all fixed up on branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
|
||
Comment 22•22 years ago
|
||
Comment on attachment 90891 [details] [diff] [review]
patch
a=chofmann
|
|
||
Comment 23•22 years ago
|
||
Comment on attachment 89636 [details] [diff] [review]
patch to freeze interface
a=chofmann
Attachment #89636 -
Flags: approval+
|
|
||
Comment 24•22 years ago
|
||
Verified Mozilla 1.1b Gecko/20020715. nsIWebBrowserPrint comments updated.
|
|
||
Comment 25•22 years ago
|
||
Also verified against the branch, Mozilla 1.0.1 Gecko/20020716. Should I change
fixed1.0.1 keyword to verifie1.0.1?
Status: RESOLVED → VERIFIED
|
|
||
Comment 26•22 years ago
|
||
Sorry about this, but I just noticed that the first parameter for print() and
printPreview() are incorrect in the comments (aThePrintOptions; should be
aThePrintSettings). Both in the trunk and branch. Should we reopen the bug, or
just file another one for this?
|
|
||
Comment 27•22 years ago
|
||
bug 158038 for the minor comments change
Keywords: fixed1.0.1 → verified1.0.1
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•