Closed Bug 99619 Opened 23 years ago Closed 22 years ago

[PATCH]Freeze nsIWebBrowserPrint

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0.1

People

(Reporter: chak, Assigned: rods)

References

()

Details

(Keywords: topembed+, Whiteboard: [adt3 RTM] [ETA 07/12])

Attachments

(2 files, 1 obsolete file)

Freeze nsIWebBrowserPrint* interfaces

Please refer to
http://www.mozilla.org/projects/embedding/EmbedInterfaceFreeze.html for the
issues to be addressed, if any, for this interface.

Please follow the guidelines outlined in "How to mark an interface as frozen?"
section of the document above.
Blocks: 98417
QA Contact: mdunn → depstein
Reassigning to Rod.
Assignee: dcone → rods
Target Milestone: --- → mozilla0.9.7
This interface will soon change to include nsIPrintSettings instead of
nsIPrintOptions
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.7 → mozilla0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.0
Moving to Moz1.1
Target Milestone: mozilla1.0 → mozilla1.1
Keywords: embed
"embed"'s dying off. topembed is the replacemnet
Keywords: embedtopembed
Moving to Moz1.0, Marking nsbeta1+, topembed+
Keywords: topembednsbeta1+, topembed+
Target Milestone: mozilla1.1 → mozilla1.0
Setting to nsbeta1-, but leaving topembed+ since this is really only needed for
embedding.
Keywords: nsbeta1+nsbeta1-
um. before you go around freezing things, please add @throws lines so that 
people can find out what are likely events.
Depends on: 136917
No longer depends on: 136917
Attached patch Patch to freeze interface (obsolete) — Splinter Review
Summary: Freeze nsIWebBrowserPrint → [PATCH]Freeze nsIWebBrowserPrint
Depends on: 115136, 135441, 144128, 144716
Depends on: 143248
Target Milestone: mozilla1.0 → mozilla1.0.1
Depends on: 149317
Attachment #82909 - Attachment is obsolete: true
Comment on attachment 89636 [details] [diff] [review]
patch to freeze interface

r=kmcclusk@netscape.com
Attachment #89636 - Flags: review+
Comment on attachment 89636 [details] [diff] [review]
patch to freeze interface

sr=sspitzer
Attachment #89636 - Flags: superreview+
changed status to "frozen" - fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Adding adt1.0.1+ on behalf of the adt for checkin to the 1.0 branch.  When you
check this into the branch, please change the mozilla1.0.1+ keyword to fixed1.0.1
Keywords: adt1.0.1adt1.0.1+
fixed on branch
nsIWebBrowserPrint iface is marked frozen. The only thing I noticed is that
'nsIWebProgressListener' is used for parameter input, instead of the actual
'aWPListener' variable in the comments description for print() and
printPreview(). Can we get that changed? Thanks.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch patchSplinter Review
Minor change to the comments for frozen interface
Status: REOPENED → ASSIGNED
Comment on attachment 90891 [details] [diff] [review]
patch

sr=waterson
Attachment #90891 - Flags: superreview+
Removing adt1.0.1 per adt because the patch hasn't landed on the trunk and also
has not been verified
Keywords: adt1.0.1
comments all fixed up on branch and trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago22 years ago
Resolution: --- → FIXED
Blocks: 143047
Whiteboard: [adt3 RTM] [ETA 07/12]
Comment on attachment 90891 [details] [diff] [review]
patch

a=chofmann
Comment on attachment 89636 [details] [diff] [review]
patch to freeze interface

a=chofmann
Attachment #89636 - Flags: approval+
Verified Mozilla 1.1b Gecko/20020715. nsIWebBrowserPrint comments updated.
Also verified against the branch, Mozilla 1.0.1 Gecko/20020716. Should I change
fixed1.0.1 keyword to verifie1.0.1?
Status: RESOLVED → VERIFIED
Sorry about this, but I just noticed that the first parameter for print() and
printPreview() are incorrect in the comments (aThePrintOptions; should be
aThePrintSettings). Both in the trunk and branch. Should we reopen the bug, or
just file another one for this?
bug 158038 for the minor comments change
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: