1441486 - Search Find Next/Previous should also jump to out-of-view <input> / <textarea> matches

Status: RESOLVED DUPLICATE of bug 1436431

(Core :: Find Backend, defect)

Description

[Jens]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180226230123

Steps to reproduce:

1. Go to a page which has long textareas / inputs with horizontal scrollbar. 

For instance go to https://github.com/JedWatson/react-select/issues/1667 (use a small Firefox window to reproduce easier)

2. Search for "aria-owns"
3. The Search toolbar correctly shows "1 of 4 matches"
4. Press <Enter> or F3 to toggle between results.



Actual results:

The search result is present 4 times on the page. But when jumping through the results only the first and second matches are shown.

This is because the "aria-owns" text match is in the not-shown / out-of-view textarea. When moving the horizontal scrollbar, then the results are shown.


Expected results:

The toolbar should also jump through *all* results. This makes it cumbersome when searching for something particular.

The bug is present in Firefox 58, 59, 60. So I do not think it is a regression.l

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
20180227100126

(In reply to Jens from comment #0)
> (use a small Firefox window to reproduce easier)
> But when jumping through the results only the first and second matches are shown.

The only way I can reproduce this is if I make the window so small that the Find Bar doesn't fit (cut off after Match Case).
Even then, F3/Next button cycles through match 1, 2, and 4, rather than 1 and 2.

Comment 2

[Jens]

Attachment: search-misses-matches.gif

Here's a GIF screenrecording showing the bug in Nightly 60 and Firefox 58. FWIW, in Nightly I have the sidebar open making the width smaller - but you have the same effect (see FF 58) when having a smaller window / screen anyway.

Comment 3

[Maverick]

I don't need to resize the window and it does not need to be horizontal scrolling. 
If SOME strings are not directly visible my Firefox can't find them.

for similar (duplicate?) references see bug 1436431 and bug 1443249

Comment 4

[Gingerbread Man]

Just to double-check, you can reproduce this in a brand new profile? [1] Reporter of bug 1443249 can't reproduce it in a brand new profile, but reporter of bug 1436431 can.


[1] https://support.mozilla.org/kb/profile-manager-create-and-remove-firefox-profiles

Comment 5

[Maverick]

(In reply to Gingerbread Man from comment #4)
> Just to double-check, you can reproduce this in a brand new profile? [1]
> Reporter of bug 1443249 can't reproduce it in a brand new profile, but
> reporter of bug 1436431 can.
> 
> 
> [1]
> https://support.mozilla.org/kb/profile-manager-create-and-remove-firefox-
> profiles

Yes! Unless i've made something wrong (i created a new profile and used it for the tests on FF59 and FF60), even with a new profile i was able to replicate the bug in the files i've sent you.

Comment 6

[Jens]

(In reply to Gingerbread Man from comment #4)
> Just to double-check, you can reproduce this in a brand new profile? [1]
> Reporter of bug 1443249 can't reproduce it in a brand new profile, but
> reporter of bug 1436431 can.

I tested bug 1441486 and bug 1443249 (because both have clear STR) with a brand-new profile. At first I could not reproduce, then after enabling at least once the Sidebar (showing history in my case) I could always reproduce. Then afterwards, even having closed the Sidebar, it was still reproducable on both bugs!

Interestingly, for one case I could always reproduce and this is matching "aria-owns" in this particular place on https://github.com/JedWatson/react-select/issues/1667 when(!) the horizontal scrollbar is at the most left (like when loading the page intially):
https://i.imgur.com/HqMv1C3.png

Comment 7

[Gingerbread Man]

Duping to bug 1436431 as per bug 1448087, comment 3.

Please test the latest Nightly in a brand new profile and reopen if the issue is still reproducible.
https://nightly.mozilla.org
https://support.mozilla.org/kb/profile-manager-create-and-remove-firefox-profiles