1442039 - Mostly remove nsDOMClassInfo

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Now that bug 888600 has landed, we can do this.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove the now-useless nsScriptNameSpaceManager::RegisterClassProto function

The only caller is nsDOMClassInfo::RegisterClassProtos.  The only caller of
that is nsDOMClassInfo::Init.  In nsDOMClassInfo::Init this is called after we
have done the RegisterClassName call for "DOMConstructor".

Since the only bits of classinfo left are DOMConstructor and DOMPrototype, and
both use nsIDOMDOMConstructor as their interface, we call RegisterClassProto
with "DOMConstructor" as aClassName, find the existing nsGlobalNameStruct, and
return without doing anything.  So this entire codepath can be removed.

MozReview-Commit-ID: JfXmIex7tLC

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove the now-unused eTypeClassProto type for nsGlobalNameStruct

MozReview-Commit-ID: H65oe2v7Gxt

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Stop trying to resolve DOMConstructor on Xrays

We don't resolve it normally, because nsDOMConstructorSH overrides
PostCreatePrototype to be a no-op, so nsWindowSH::GlobalResolve never actually
defines the relevant property on the window.  We also hide it in
nsWindowSH::NameStructEnabled.  But in the Xray-to-window case we attempt to
define it.  We shouldn't do that.

MozReview-Commit-ID: 3tnMnSQuvuT

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove the dead code in nsDOMClassInfo::PostCreatePrototype

We only have classinfo left for DOMConstructor and DOMPrototype, both of which
use nsDOMConstructorSH, which overrides PostCreatePrototype.

To avoid -Werror build failures, this changeset also removes static functions
that were only reachable from PostCreatePrototype.

MozReview-Commit-ID: JpJOuMHAAuo

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Remove the now-dead nsDOMConstructor class

The only caller of nsDOMConstructor::nsDOMConstructor is
nsDOMConstructor::Create which has no callers.

Also removes the now-unused nsDOMConstructorSH class.

MozReview-Commit-ID: GgOO8ugXFKb

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 6. Remove now-unused classinfo bits for DOMConstructor and DOMPrototype

Also removes various code that stops compiling this way and static functions
that are now unused.

MozReview-Commit-ID: KHYxly2c3Id

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: part 7. Remove now-unused nsScriptNameSpaceManager::RegisterClassName

MozReview-Commit-ID: 9mpz8o29WGp

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: part 8. Remove now-unused eTypeClassConstructor type of nsGlobalNameStruct

GetXPCProto is now static and not called, so needs to go too.

MozReview-Commit-ID: I6DilDx2e2m

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: part 9. Remove now-unused NS_GetDOMClassInfoInstance

MozReview-Commit-ID: 5JpNuBq5RUg

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: part 10. Remove now-unused nsEventTargetSH

MozReview-Commit-ID: WocCkriliI

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: part 11. Remove all the non-static bits from nsDOMClassInfo

MozReview-Commit-ID: 7J8hsPuYtPa

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: part 12. Remove various unused static stuff from nsDOMClassInfo

MozReview-Commit-ID: Imt658SuM9w

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: part 13. Remove the now-pointless nsWindowSH::NameStructEnabled

MozReview-Commit-ID: 9lawfsdyyZq

Comment 14

[Boris Zbarsky [:bzbarsky]]

Attachment: part 14. Remove nsDOMClassInfoID.h

MozReview-Commit-ID: 6pZs1XI1oSd

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: part 15. Remove nsIDOMDOMConstructor

MozReview-Commit-ID: KmIhVN7TeNN

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5900a3a5a232
part 1.  Remove the now-useless nsScriptNameSpaceManager::RegisterClassProto function.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/e75da32a2992
part 2.  Remove the now-unused eTypeClassProto type for nsGlobalNameStruct.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/20d2f8bbd902
part 3.  Stop trying to resolve DOMConstructor on Xrays.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f4d03bae224
part 4.  Remove the dead code in nsDOMClassInfo::PostCreatePrototype.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/96295638ca8e
part 5.  Remove the now-dead nsDOMConstructor class.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4492fdf4a10
part 6.  Remove now-unused classinfo bits for DOMConstructor and DOMPrototype.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a44d04d09bf
part 7.  Remove now-unused nsScriptNameSpaceManager::RegisterClassName.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/316552bee730
part 8.  Remove now-unused eTypeClassConstructor type of nsGlobalNameStruct.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a8c0603d612
part 9.  Remove now-unused NS_GetDOMClassInfoInstance.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/58c5cfca84ff
part 10.  Remove now-unused nsEventTargetSH.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/e609ee0164b0
part 11.  Remove all the non-static bits from nsDOMClassInfo.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a5c2206177
part 12.  Remove various unused static stuff from nsDOMClassInfo.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a94ee5c9105
part 13.  Remove the now-pointless nsWindowSH::NameStructEnabled.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/b68c19a47cab
part 14.  Remove nsDOMClassInfoID.h.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/9624e53b439e
part 15.  Remove nsIDOMDOMConstructor.  r=petev

Comment 17

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5900a3a5a232
https://hg.mozilla.org/mozilla-central/rev/e75da32a2992
https://hg.mozilla.org/mozilla-central/rev/20d2f8bbd902
https://hg.mozilla.org/mozilla-central/rev/6f4d03bae224
https://hg.mozilla.org/mozilla-central/rev/96295638ca8e
https://hg.mozilla.org/mozilla-central/rev/b4492fdf4a10
https://hg.mozilla.org/mozilla-central/rev/9a44d04d09bf
https://hg.mozilla.org/mozilla-central/rev/316552bee730
https://hg.mozilla.org/mozilla-central/rev/1a8c0603d612
https://hg.mozilla.org/mozilla-central/rev/58c5cfca84ff
https://hg.mozilla.org/mozilla-central/rev/e609ee0164b0
https://hg.mozilla.org/mozilla-central/rev/a9a5c2206177
https://hg.mozilla.org/mozilla-central/rev/4a94ee5c9105
https://hg.mozilla.org/mozilla-central/rev/b68c19a47cab
https://hg.mozilla.org/mozilla-central/rev/9624e53b439e