Closed Bug 1442330 Opened 2 years ago Closed 2 years ago

Stop producing Nightly oldid builds

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: catlee, Assigned: catlee)

References

Details

Attachments

(1 file)

Let's first look at telemetry and find out how many users we still have running the oldid build.
Flags: needinfo?(s.kaspari)
Depends on: 1354821
I do find these builds useful. It allows me to run o.m.fennec_aurora as my primary browser and use o.m.fennec as a browser for testing bugs.

I understand that the cost and complexity is non-trivial and it may be time to shut down the oldid.
Looking at the "core ping" it seems like we can't distinguish the builds. We do not report the application id.

sylvestre, nalexander: Do you have an idea what other metric we could use? ADI? Crash Stats? Or maybe our own update service that only the oldid build should use?
Flags: needinfo?(sledru)
Flags: needinfo?(s.kaspari)
Flags: needinfo?(nalexander)
Calixte, do you remember how to do that?
Flags: needinfo?(sledru) → needinfo?(cdenizet)
Depending on the number of affected users, it would be nice to get bug 1427794 working at least on Nightly only beforehand, so users could simply copy their profile over to the "new" Nightly (Sync doesn't cover everything, like add-ons or preferences).
AFAIK we've nothing in neither telemetry nor crash-stats.
:sylvestre, maybe we could have numbers from Google Play.
Flags: needinfo?(cdenizet)
I don't have such information in Google play as the old-id hasn't been uploaded here.
I will share some stats in private in my next comments but I guess this isn't a big deal if we just drop it.
Maybe we could use Leanplum to send a message to our users to use the Google play version or the other (aurora) id.
(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> Looking at the "core ping" it seems like we can't distinguish the builds. We
> do not report the application id.
> 
> sylvestre, nalexander: Do you have an idea what other metric we could use?
> ADI? Crash Stats? Or maybe our own update service that only the oldid build
> should use?

I am not really seeing anything other than the update service.  We used to use blocklist pings for this type of stuff, but I doubt they distinguish the Android package.  (I can't believe we don't include our own package in our telemetry ping!)

It looks like the oldid Apps use the same Leanplum registration details as the newid Apps, so it would be up to Leanplum to be able to target by Android package name.  I think Leanplum does this.
Flags: needinfo?(nalexander)
What do we need to make a decision here?

Or do we think that remaining users are few enough that we can simply turn these off?
Andreas, could you have a look how we could use leanplum to target only users of the old nightly id? Thanks
Flags: needinfo?(abovens)
Sorry for the late follow-up. I'm afraid I can't help much with this, so let me loop in Jean.
Flags: needinfo?(abovens) → needinfo?(jcollings)
How do we know if they are using an old Nightly id? Is it by App version or OS version or something else? 

Here's the general targeting that can be done in Leanplum (and we have the Firefox Android Nightly app on Leanplum): 

https://support.leanplum.com/hc/en-us/articles/115003472403-Segment-and-target-criteria-options
Flags: needinfo?(jcollings)
(In reply to Jean Collings from comment #12)
> How do we know if they are using an old Nightly id? Is it by App version or
> OS version or something else? 
> 
> Here's the general targeting that can be done in Leanplum (and we have the
> Firefox Android Nightly app on Leanplum): 
> 
> https://support.leanplum.com/hc/en-us/articles/115003472403-Segment-and-
> target-criteria-options

I think the only way to distinguish is by application id.
Based on the number of requests we're seeing to Balrog, we can turn these off now.

Any users still on these should re-install the regular version of Fennec Nightly.
Assignee: nobody → catlee
Attachment #8964531 - Flags: review?(jlorenzo)
Comment on attachment 8964531 [details]
Bug 1442330: Remove android old-id builds

https://reviewboard.mozilla.org/r/233256/#review238856

Great to see this code deleted! I ran a few commands[1] to see if some references were missed. The only occurence was this folder:
> mobile/android/branding/nightly-old-id

Do we want to keep it?

[1] find . -iregex '.*old[^a-zA-Z]id.*' ; rg -i 'old[^a-zA-Z]id'
Attachment #8964531 - Flags: review?(jlorenzo) → review+
(In reply to Johan Lorenzo [:jlorenzo] from comment #16)
> Comment on attachment 8964531 [details]
> Bug 1442330: Remove android old-id builds
> 
> https://reviewboard.mozilla.org/r/233256/#review238856
> 
> Great to see this code deleted! I ran a few commands[1] to see if some
> references were missed. The only occurence was this folder:
> > mobile/android/branding/nightly-old-id
> 
> Do we want to keep it?
> 
> [1] find . -iregex '.*old[^a-zA-Z]id.*' ; rg -i 'old[^a-zA-Z]id'

No, get rid of branding/nightly-old-id -- those directories correspond to the mozconfigs that are being removed.
Good catch - I removed those files in the latest version of the patch on mozreview.
Pushed by catlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f3d33f7c72b
Remove android old-id builds r=jlorenzo
https://hg.mozilla.org/mozilla-central/rev/8f3d33f7c72b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
See Also: → 1452440
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.