1442412 - Move MOZ_OPTIMIZE_FLAGS differences from js/src/old-configure.in to js/src/moz.build

Status: NEW

(Firefox Build System :: General, task)

Description

[(not currently active) Ted Mielczarek]

js/src has different values of `MOZ_OPTIMIZE_FLAGS` than the root old-configure.in for some platforms. bug 680515 moved them from js/src/Makefile.in to configure.

I have patches to move `MOZ_OPTIMIZE_FLAGS` to toolchain.configure, but I'd rather not have to add conditionals for js_standalone, so it'd be easier to just move the few extra things JS wants into its moz.build, which should work fine and not hit the issues that we were fixing by moving them to configure in that other bug.

Comment 1

[(not currently active) Ted Mielczarek]

js/src adds -fno-stack-protector on mac:
https://dxr.mozilla.org/mozilla-central/rev/b996cabc7ef54bbe050d647494bf00d668ec52e6/js/src/old-configure.in#565
https://dxr.mozilla.org/mozilla-central/rev/b996cabc7ef54bbe050d647494bf00d668ec52e6/old-configure.in#761

The optimization flags for Android are different:
https://dxr.mozilla.org/mozilla-central/rev/b996cabc7ef54bbe050d647494bf00d668ec52e6/js/src/old-configure.in#613
https://dxr.mozilla.org/mozilla-central/rev/b996cabc7ef54bbe050d647494bf00d668ec52e6/old-configure.in#820

On Linux it uses -O3 instead of -O2/-Os depending on MOZ_DEBUG:
https://dxr.mozilla.org/mozilla-central/rev/b996cabc7ef54bbe050d647494bf00d668ec52e6/js/src/old-configure.in#622
https://dxr.mozilla.org/mozilla-central/rev/b996cabc7ef54bbe050d647494bf00d668ec52e6/old-configure.in#832

and -O2 instead of -O1 -Oi on Windows:
https://dxr.mozilla.org/mozilla-central/rev/b996cabc7ef54bbe050d647494bf00d668ec52e6/js/src/old-configure.in#779
https://dxr.mozilla.org/mozilla-central/rev/b996cabc7ef54bbe050d647494bf00d668ec52e6/old-configure.in#1019